Add 'CSharpVersion7' member into public 'Language' enum#3933
Add 'CSharpVersion7' member into public 'Language' enum#3933
Conversation
Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp' already contains 'CSharp7' member. After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7' member into public 'Microsoft.PowerShell.Commands.Language' enum too. This will allow 'Add-Type -Language CSharpVersion7'
| It "Public 'Language' enumeration contains all members" { | ||
| [Enum]::GetNames("Microsoft.PowerShell.Commands.Language") -join "," | Should Be "CSharp,CSharpVersion7,CSharpVersion6,CSharpVersion5,CSharpVersion4,CSharpVersion3,CSharpVersion2,CSharpVersion1,VisualBasic,JScript" | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we add a test case for 'Add-Type -Language CSharpVersion7'?
There was a problem hiding this comment.
Also, should there be two commits (one for the product change and one for the test)?
There was a problem hiding this comment.
We checked it manually in the original Issue.
I didn't touch the functionality of this cmdlet. Besides, we don't even have tests for it right now. So I believe this is a separate huge job.
It seems @daxian-dbw is working on Add-Type. It would be good to agree on the distribution of work on tests.
I can say nothing about separate commits. 😕
There was a problem hiding this comment.
Two commits (one for code changes and one for tests) is not a strict requirement.
|
@mirichmo Could you please continue with the PR? |
Close #3853
Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp'
already contains 'CSharp7' member.
After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7'
member into public 'Microsoft.PowerShell.Commands.Language' enum too.
This will allow 'Add-Type -Language CSharpVersion7'