Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove BuildVersion from $PSVersionTable#3877

Merged
vors merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:remove-buildversioniSazonov/PowerShell:remove-buildversionCopy head branch name to clipboard
Jun 1, 2017
Merged

Remove BuildVersion from $PSVersionTable#3877
vors merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:remove-buildversioniSazonov/PowerShell:remove-buildversionCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented May 29, 2017

Copy link
Copy Markdown
Collaborator

Close #1415

Motivation

PowerShell Committee concluded to remove BuildVersion property from $PSVersionTable as unneeded - now we use new GitCommitId property.

Fix

Remove BuildVersion from PSVersionHashTable and PSVersionInfo types and replace BuildVersion with GitCommitId in codes.

@iSazonov iSazonov changed the title Remove BuildVersion from PSVersionInfo type Remove BuildVersion from $PSVersionTable May 29, 2017
@iSazonov iSazonov force-pushed the remove-buildversion branch from 4ec781e to da609ce Compare May 29, 2017 05:54
@iSazonov

Copy link
Copy Markdown
Collaborator Author

CI AppVeyor is failed on Set-Content.Tests.ps1 tests - it seems it is not related to the PR changes 😕

@iSazonov iSazonov requested a review from SteveL-MSFT June 1, 2017 16:05

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vors vors merged commit 9c42d2d into PowerShell:master Jun 1, 2017
@iSazonov iSazonov deleted the remove-buildversion branch June 2, 2017 03:01
@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Jun 17, 2017
@joeyaiello joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.