Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add Homebrew to install docs#3838

Merged
mirichmo merged 5 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
joeyaiello:HomebrewDocsjoeyaiello/PowerShell:HomebrewDocsCopy head branch name to clipboard
Aug 7, 2017
Merged

Add Homebrew to install docs#3838
mirichmo merged 5 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
joeyaiello:HomebrewDocsjoeyaiello/PowerShell:HomebrewDocsCopy head branch name to clipboard

Conversation

@joeyaiello

Copy link
Copy Markdown
Contributor

Fixes #1779

It would be awesome if someone who actually has a Mac (like @JamesWTruher or @BrucePay) can validate these instructions before we merge them.

Also, it would be great to know how accurate these directions currently are. The reference to .NET Core 1.0.0 makes me think it might be a little outdated.

Comment thread docs/installation/linux.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i needed to do brew cask uninstall powershell

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Comment thread docs/installation/linux.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think these are right - they're not working for me. I get an error message:

brew upgrade powershell
Error: No available formula with the name "powershell" 

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about brew cask upgrade powershell?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew cask reinstall powershell

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, reinstall is the upgrade command?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting...thanks for the pointer. Looks like that's the way to go now. I'm updating the docs accordingly.

@mirichmo mirichmo self-assigned this May 24, 2017
@SteveL-MSFT SteveL-MSFT removed their request for review June 1, 2017 16:37
Comment thread docs/installation/linux.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is installation instruction for cask.
It's not clear from the comment that these two lines correspond to two steps above.

I'd break it down into two parts.

Comment thread docs/installation/linux.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe If you PowerShell installed with Homebrew ? Not an English expert, but this language feels too playful :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahahaha, I just accidentally a word.

Comment thread docs/installation/linux.md Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is auto-included in powershell brew formula (it's a dependency I think)
Worth pointing out here that it's not required as a separate step with brew.

@mirichmo

mirichmo commented Jun 6, 2017

Copy link
Copy Markdown
Member

@joeyaiello Don't forget about this one

@joeyaiello

joeyaiello commented Jun 6, 2017

Copy link
Copy Markdown
Contributor Author

@mirichmo I hadn't! I just didn't realize anyone had responded yet. It's hard for me to get this one right because I don't actually have a Mac....

@mirichmo

Copy link
Copy Markdown
Member

@vors - Are all your concerns addressed?

@joeyaiello

Copy link
Copy Markdown
Contributor Author

@mirichmo sorry, this is on me. I've been meaning to grab the Macbook from @daxian-dbw, gotta do my validation real quick.

@joeyaiello

Copy link
Copy Markdown
Contributor Author

Okay, sorry for taking so long on this. @mirichmo: it should be good to go now. I validated all the instructions on a Macbook. :)

@mirichmo

Copy link
Copy Markdown
Member

@vors Do you have any additional comments or concerns?

@jpogran

jpogran commented Jul 11, 2017

Copy link
Copy Markdown

FWIW, followed these instructions on macOS 10.12.5 with homebrew and cask and it worked for me

@joeyaiello

Copy link
Copy Markdown
Contributor Author

@mirichmo I think I have enough approval (and have adequately addressed @vors' concerns).

@mirichmo mirichmo merged commit 487159d into PowerShell:master Aug 7, 2017
@joeyaiello joeyaiello deleted the HomebrewDocs branch August 8, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Maintainers-Documentation specific to documentation in this repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.