Download.sh that autodetects current release from github#3535
Download.sh that autodetects current release from github#3535DarwinJS wants to merge 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom DarwinJS:feature-downloadsh-currentver-autodetectCopy head branch name to clipboard
Conversation
Autodetects current release from github using pure bash (sed)
|
@DarwinJS, |
|
|
||
| case "$VERSION_ID" in | ||
| 14.04) | ||
| package=powershell_6.0.0-alpha.18-1ubuntu1.14.04.1_amd64.deb |
There was a problem hiding this comment.
Where installation via package manager is available, can we switch to using that?
There was a problem hiding this comment.
We're on the same page! I am thinking that when I add the repos I should make the initial install request specifying the version as the version that comes down in the version tag on git. That way if there happens to a sync issue where a newer than the latest "official" release is hanging around, this code only installs the official release tagged as latest on git?
There was a problem hiding this comment.
I think it should just install the latest version from the repo. Eventually, we will have a non-pre-release version, and I think then we have a decision to make, but currently, if it's in the repo, it's ready.
There was a problem hiding this comment.
Suits me - easier to code ;)
TravisEz13
left a comment
There was a problem hiding this comment.
The build is failing. It should be fixed
|
Another question - is the "Centos" release really only good for Centos - or also Rhel? Right now the logic limits it to Centos. |
|
CentOS, my understanding is that it should work on the same version of Rhel. |
|
I've made a proposal here: #3547 |
|
@TravisEz13 - is every .sh that is uploaded tested against every distro - or is there a way to specify which ones run on which test targets? |
|
Which .sh file are we talking about? I doubt there is a way to specify which distro it is tested on. that would have to be written. |
|
What do you want to do with this PR? |
|
I would like to merge it, however, I don't have a way to test the OSX code (that now uses brew.) Would be especially helpful to test on a pristine system. |
|
If you fix the merge conflicts, I can probably help you test it. |
|
@TravisEz13 - this is superceded by #3608 |
|
Closing because this is superseded |
This version detects the currently available version on github.
Details: