Add Metatests#3504
Add Metatests#3504iSazonov wants to merge 2 commits into
Conversation
1949a1e to
b17deb7
Compare
|
I think it's more common to use git commit hooks to enforce the sorts of things this PR is trying to catch. |
|
It seems users (IDEs) can silently ignore hooks. So anyway we need scripts to perform approved checks. |
|
An IDE could not ignore a server side hook. |
|
People can all :-) With specific regard to hooks, GitHub addins look more attractive. If MSFT can turn such addins for code checks it will be great. Is it possible? |
|
There is code to automatically fix most of the tests you have added here: https://github.com/PowerShell/DscResource.Tests/blob/dev/MetaFixers.psm1 I'd say we separate the hook issue. These tests should be identified in some way that we can create a hook, but we need the tests before we can create a hook. |
|
@TravisEz13 Thanks! We should be careful with MetaFixers.psm1:
What is our plan? What should I do next? |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. Thank you for your contributions. |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Related #3347
It is expected that the AppVeyor CI failed.
The meta tests run only on AppVeyor CI and locally.
The meta tests by default check only new and changed files from "current" PR (compared with origin/master).
Therefore, the PR for demo includes test files for each type of validation - this is what causes CI tests to fail. These test files should be deleted before merge.
Now check of all files in Repo is blocked. We can allow it if necessary for example for night builds.
After merging the PR we will have to produce every modified file in line with the meta tests.