Updating dockerfiles for Windows#3017
Updating dockerfiles for Windows#3017brycem wants to merge 3 commits into
Conversation
Cleaned up RELEASE versions, and adding initial version of CI-friendly NIGHTLY dockerfile for WindowsServerCore
Core build works, -FullCLR doesn't yet.
|
Can you document how the image We are discussing not building the C/C++ Windows components in PowerShell/PowerShell and instead pull packages from NuGet - would this eliminate the need for your custom image? |
|
That would be a much cleaner solution. Heres the image and a link to the dockerfile in git https://hub.docker.com/r/brycem/win10build/
Outlook für Android herunterladen
On Mon, Jan 23, 2017 at 1:10 PM -0800, "Jason Shirk" <notifications@github.com<mailto:notifications@github.com>> wrote:
Can you document how the image brycem/win10build was built?
We are discussing not building the C/C++ Windows components in PowerShell/PowerShell and instead pull packages from NuGet - would this eliminate the need for your custom image?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3017 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGgSlC3BAilzaxU9boofM4EwIGmRohcSks5rVRdOgaJpZM4Lnwdl>.
|
|
@lzybkr - Where did you guys shake out on removing the Standalone Win10SDK dependency? It would definitely simplify. Looks like CMake is available in NuGet as well. |
Codecov Report
Continue to review full report at Codecov.
|
|
I filed issue #3014, but it hasn't progressed beyond that. |
|
@raghushantha - Can you please take a look? |
| If ($ZipHash -notmatch $Env:POWERSHELL_SHA256){` | ||
| Throw [String]$('['+$ZipHash+'] does not match ['+$Env:POWERSHELL_SHA256+']!')` | ||
| }` | ||
| [System.IO.DirectoryInfo]$PsFolder=New-Item -Path $Env:ProgramFiles\PowerShell -ItemType Directory -Force;` |
There was a problem hiding this comment.
Expand-Archive would simplify this. Here is an example.
|
|
||
| ARG POWERSHELL_MSI=https://github.com/PowerShell/PowerShell/releases/download/v6.0.0-alpha.14/PowerShell_6.0.0.14-alpha.14-win10-x64.msi | ||
| ARG POWERSHELL_SHA256=503F3AD52223699765895D3E9615FBD7988194693BCB725BE90C9EF0CD594447 | ||
| ARG POWERSHELL_MSI=https://github.com/PowerShell/PowerShell/releases/download/v6.0.0-alpha.15/PowerShell_6.0.0-alpha.15-win10-win2k16-x64.msi |
There was a problem hiding this comment.
@brycem Please pick up the latest release MSI here
https://github.com/PowerShell/PowerShell/releases/latest
Then the experience would be similar to Linux. There we simply apt-get install / yum install from packages.microsoft.com and the image is automatlically populated with latest PS
This comment applies all locations where the MSI is downloaded
| ARG POWERSHELL_MSI=https://github.com/PowerShell/PowerShell/releases/download/v6.0.0-alpha.14/PowerShell_6.0.0.14-alpha.14-win10-x64.msi | ||
| ARG POWERSHELL_SHA256=503F3AD52223699765895D3E9615FBD7988194693BCB725BE90C9EF0CD594447 | ||
| ARG POWERSHELL_MSI=https://github.com/PowerShell/PowerShell/releases/download/v6.0.0-alpha.15/PowerShell_6.0.0-alpha.15-win10-win2k16-x64.msi | ||
| ARG POWERSHELL_SHA256=CC52D21F3287E412B9C3B73C98BB5B06F8056D49D63201072216DF92B7F2E59B |
There was a problem hiding this comment.
Not really required to validate the hash. The MSI is authenticode signed & you are downloading from an HTTPS location
|
Looks like @TravisEz13 has updated the URLs in #3508 - I'll close this PR |
Cleaned up RELEASE version Dockerfiles for Windows