Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove Test-Bom and the boms JSON files - #27726

#27726
Merged
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:cleanupdaxian-dbw/PowerShell:cleanupCopy head branch name to clipboard
Jul 24, 2026
Merged

Remove Test-Bom and the boms JSON files#27726
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:cleanupdaxian-dbw/PowerShell:cleanupCopy head branch name to clipboard

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented Jul 24, 2026

Copy link
Copy Markdown
Member

PR Summary

Test-Bom was only used in New-MSIPackage, which was removed in #27213 as we are not building MSI packages for v7.7 and onward.

Test-Bom is no longer used anywhere in PowerShell repo, so removing it and its helpers, as well as the boms JSON files, in this PR.

PR Checklist

Copilot AI review requested due to automatic review settings July 24, 2026 00:11
@daxian-dbw
daxian-dbw requested review from a team and jshigetomi as code owners July 24, 2026 00:11
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@daxian-dbw daxian-dbw added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the now-unused Test-Bom functionality (and its helper class/functions) from the packaging module, along with the large BOM JSON inventories, following the earlier removal of MSI packaging where Test-Bom was previously used.

Changes:

  • Deleted Test-Bom, BomRecord, and Test-IsProductFile from tools/packaging/packaging.psm1.
  • Removed Test-Bom from the module’s exported functions list in tools/packaging/packaging.psd1.
  • Deleted the platform BOM JSON files under tools/packaging/boms/.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/packaging/packaging.psm1 Removes the unused BOM verification implementation and related helpers.
tools/packaging/packaging.psd1 Stops exporting Test-Bom from the packaging module manifest.
tools/packaging/boms/windows.json Deletes the unused Windows BOM inventory file.
tools/packaging/boms/mac.json Deletes the unused macOS BOM inventory file.
tools/packaging/boms/linux.json Deletes the unused Linux BOM inventory file.

@daxian-dbw
daxian-dbw merged commit db5f4f3 into PowerShell:master Jul 24, 2026
46 of 48 checks passed
@daxian-dbw
daxian-dbw deleted the cleanup branch July 24, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.