-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[release/v7.6.1] Download PMC Packages through TemplateContext
#27331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -67,7 +67,7 @@ extends: | |||
| exactToolVersion: 4.4.2 | ||||
| policheck: | ||||
| break: true # always break the build on policheck issues. You can disable it by setting to 'false' | ||||
| tsaOptionsFile: .config\tsaoptions.json | ||||
| tsaOptionsFile: $(Build.SourcesDirectory)\.config\tsaoptions.json | ||||
|
| tsaOptionsFile: $(Build.SourcesDirectory)\.config\tsaoptions.json | |
| tsaOptionsFile: $(Build.SourcesDirectory)\PowerShell\.config\tsaoptions.json |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,37 +1,56 @@ | ||||||
| parameters: | ||||||
| - name: releaseEnvironment | ||||||
| type: string | ||||||
| default: Production | ||||||
| values: | ||||||
| - Production | ||||||
| - PPE | ||||||
| - Test | ||||||
| - name: approvalServiceEnvironment | ||||||
| type: string | ||||||
| default: Production | ||||||
| values: | ||||||
| - Production | ||||||
| - PPE | ||||||
| - Test | ||||||
| # OneBranch requires the stage name to be prefixed with the release environment. | ||||||
| # Official uses 'Prod' for Production; NonProd validators require '<env>' (e.g. 'Test', 'PPE'). | ||||||
| - name: stagePrefix | ||||||
| type: string | ||||||
| default: Prod | ||||||
| # When true, the Ev2 push step is skipped. Useful for NonOfficial dry-runs that | ||||||
| # only want to validate artifact download via templateContext.inputs. | ||||||
| - name: skipEv2Push | ||||||
| type: boolean | ||||||
| default: false | ||||||
|
|
||||||
| stages: | ||||||
| - stage: 'Prod_Release' | ||||||
| - stage: ${{ parameters.stagePrefix }}_Release | ||||||
| displayName: 'Deploy packages to PMC with EV2' | ||||||
| dependsOn: | ||||||
| - PrepForEV2 | ||||||
| variables: | ||||||
| - name: ob_release_environment | ||||||
| value: "Production" | ||||||
| value: ${{ parameters.releaseEnvironment }} | ||||||
| - name: repoRoot | ||||||
| value: $(Build.SourcesDirectory) | ||||||
| jobs: | ||||||
| - job: Prod_ReleaseJob | ||||||
| - job: ${{ parameters.stagePrefix }}_ReleaseJob | ||||||
| displayName: Publish to PMC | ||||||
| pool: | ||||||
| type: release | ||||||
|
| type: release | |
| type: release | |
| os: windows |
Copilot
AI
Apr 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When skipEv2Push is true, this job expands to having no steps at all (the only step is conditionally omitted). That makes the NonOfficial “dry-run” stage less useful for validating the downloaded EV2 payload and can also be brittle for pipeline diagnostics. Consider adding a lightweight validation/logging step (e.g., list $(Pipeline.Workspace)/EV2Specs or assert RolloutSpec.json exists) that runs when skipEv2Push is true (or always).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsaOptionsFilenow points to$(Build.SourcesDirectory)\.config\tsaoptions.json, but these OneBranch pipelines commonly have the repo under$(Build.SourcesDirectory)\PowerShell(templates defaultREPOROOTaccordingly). This path may not exist and can break TSA upload. Update to$(Build.SourcesDirectory)\PowerShell\.config\tsaoptions.json(or use a repo-relative.config\tsaoptions.jsonif required by the governed template).