[release/v7.5.6] Fix the APIScan pipeline#27276
Merged
daxian-dbw merged 2 commits intoApr 15, 2026
PowerShell:release/v7.5.6PowerShell/PowerShell:release/v7.5.6from
daxian-dbw:backport/release/v7.5.6/26016-cfc0bcd9fdaxian-dbw/PowerShell:backport/release/v7.5.6/26016-cfc0bcd9fCopy head branch name to clipboard
Merged
[release/v7.5.6] Fix the APIScan pipeline#27276daxian-dbw merged 2 commits intoPowerShell:release/v7.5.6PowerShell/PowerShell:release/v7.5.6from daxian-dbw:backport/release/v7.5.6/26016-cfc0bcd9fdaxian-dbw/PowerShell:backport/release/v7.5.6/26016-cfc0bcd9fCopy head branch name to clipboard
daxian-dbw merged 2 commits into
PowerShell:release/v7.5.6PowerShell/PowerShell:release/v7.5.6from
daxian-dbw:backport/release/v7.5.6/26016-cfc0bcd9fdaxian-dbw/PowerShell:backport/release/v7.5.6/26016-cfc0bcd9fCopy head branch name to clipboard
Conversation
1. When removing unused runtimes, keep the `win` and `win-x64` runtime folders. 2. Stop downloading `getfilesiginforedist.dll` from Azure blob. The original `getfilesiginforedist.dll` produced from the build works fine with the symbols retrieved by `dotnet-symbols`.
|
Azure Pipelines: 5 pipeline(s) require an authorized user to comment /azp run to run. |
|
Azure Pipelines: 5 pipeline(s) require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.5.6 to fix the APIScan validation pipeline by adjusting how build outputs/runtimes are prepared and removing reliance on an externally downloaded getfilesiginforedist.dll.
Changes:
- Remove Azure Blob variable group usage and the AzurePowerShell download step for
getfilesiginforedist.dll. - Ensure the OneBranch output directory exists before copying build outputs into it.
- Update runtime-pruning logic to retain Windows runtimes and delete non-Windows (and certain Windows) runtime folders.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pipelines/templates/compliance/apiscan.yml |
Removes blob download step; improves output folder handling; updates runtime cleanup logic used by APIScan. |
.pipelines/apiscan-gen-notice.yml |
Adjusts APIScan SDL configuration (including versionNumber). |
| # Only key windows runtimes | ||
| Get-ChildItem -Path '$(ob_outputDirectory)\runtimes\*' -File -Recurse | Where-Object {$_.FullName -notmatch '.*\/runtimes\/win'} | Foreach-Object { | ||
| # Only keep windows runtimes | ||
| Write-Verbose -Verbose -Message "Deleting non-win-x64 runtimes ..." |
There was a problem hiding this comment.
The log message says "Deleting non-win-x64 runtimes", but the filter keeps both runtimes\win and runtimes\win-x64 (and only later removes win-x86/win-arm*). This message is misleading when troubleshooting pipeline failures; consider updating it to reflect the actual behavior (e.g., deleting non-Windows runtimes, then deleting win-x86/win-arm*).
Suggested change
| Write-Verbose -Verbose -Message "Deleting non-win-x64 runtimes ..." | |
| Write-Verbose -Verbose -Message "Deleting non-Windows runtimes ..." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26016 to release/v7.5.6
Triggered by @daxian-dbw on behalf of @daxian-dbw
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Fixes the APIScan pipeline: keeps
winandwin-x64runtime folders when removing unused runtimes, and stops downloadinggetfilesiginforedist.dllfrom Azure blob (the build-produced version works correctly withdotnet-symbols).Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
The APIScan validation pipeline was run and passed successfully. This change only affects CI/build tooling with no user-facing code changes, so no new automated tests are needed.
Risk
REQUIRED: Check exactly one box.
This is a CI/build pipeline-only fix with no changes to user-facing PowerShell code. The risk of regression is minimal.