Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Build, package, and create VPack for the PowerShell-LTS store package within the same msixbundle-vpack pipeline (#150)#27209

Merged
daxian-dbw merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:update-msix-vpackdaxian-dbw/PowerShell:update-msix-vpackCopy head branch name to clipboard
Apr 8, 2026
Merged

Build, package, and create VPack for the PowerShell-LTS store package within the same msixbundle-vpack pipeline (#150)#27209
daxian-dbw merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:update-msix-vpackdaxian-dbw/PowerShell:update-msix-vpackCopy head branch name to clipboard

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Apr 8, 2026

PR Summary

Update the MSIXBundle-vPack-Official.yml to build, package, and then create VPack for the PowerShell-LTS store package.
It's a compliance requirement to build and package from scratch in a VPack pipeline in order to create the VPack pacakge.

This PR also enable publishing symbol files in the same pipeline.

PR Checklist

@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners April 8, 2026 17:23
@daxian-dbw daxian-dbw requested review from TravisEz13 and Copilot April 8, 2026 17:23
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the MSIXBundle-vPack-Official.yml pipeline to satisfy compliance by rebuilding and packaging the PowerShell-LTS Store MSIX artifacts from source within the same vPack pipeline before creating/submitting the vPack.

Changes:

  • Replace artifact-download-based bundling with in-pipeline build + unsigned MSIX creation for x64/arm64, then bundle + sign + stage for vPack.
  • Add a symbols publish stage that downloads zipped PDB artifacts and publishes them.
  • Minor refactors/wording updates across packaging scripts, telemetry calls, and resource strings.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tools/packaging/packaging.psm1 Minor comment/whitespace cleanup in MSIX packaging function.
src/System.Management.Automation/utils/Telemetry.cs Small refactor (property initializer removed; simplify calls to telemetry metric sender).
src/System.Management.Automation/resources/TabCompletionStrings.resx Update tab-completion descriptions to reference “PowerShell 7+” / “Windows PowerShell 5.1”.
src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Update remoting error string to “PowerShell 7+”.
src/Microsoft.PowerShell.ConsoleHost/resources/ManagedEntranceStrings.resx Rename banner resource key used by ConsoleHost.
src/Microsoft.PowerShell.ConsoleHost/host/msh/ManagedEntrance.cs Update banner resource usage and make local type explicit.
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs Adjust redirected-output flag assignment target.
PowerShell.Common.props Minor formatting change in MSBuild condition expression.
.pipelines/MSIXBundle-vPack-Official.yml Major pipeline restructure: build/package from source, create/sign bundle, create vPack, publish symbols, add network isolation parameter.

Comment thread .pipelines/MSIXBundle-vPack-Official.yml
Comment thread .pipelines/MSIXBundle-vPack-Official.yml
Comment thread .pipelines/MSIXBundle-vPack-Official.yml
Comment thread .pipelines/MSIXBundle-vPack-Official.yml
Comment thread .pipelines/MSIXBundle-vPack-Official.yml
Comment thread .pipelines/MSIXBundle-vPack-Official.yml
Comment thread .pipelines/MSIXBundle-vPack-Official.yml Outdated
daxian-dbw added a commit to daxian-dbw/PowerShell that referenced this pull request Apr 9, 2026
daxian-dbw added a commit to daxian-dbw/PowerShell that referenced this pull request Apr 9, 2026
JustinGrote pushed a commit to JustinGrote/PowerShell that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Done Backport-7.5.x-Done Backport-7.6.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.