Fix csv cmdlets to use default delimiter with -UseCulture:False#27036
Open
evalentini wants to merge 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
evalentini:fix-useculture-false-26513evalentini/PowerShell:fix-useculture-false-26513Copy head branch name to clipboard
Open
Fix csv cmdlets to use default delimiter with -UseCulture:False#27036evalentini wants to merge 3 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom evalentini:fix-useculture-false-26513evalentini/PowerShell:fix-useculture-false-26513Copy head branch name to clipboard
-UseCulture:False#27036evalentini wants to merge 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
evalentini:fix-useculture-false-26513evalentini/PowerShell:fix-useculture-false-26513Copy head branch name to clipboard
Conversation
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix
ConvertTo-Csv -UseCulture:$FalseandExport-Csv -UseCulture:$Falseto use default comma delimiter.Fixes #26513
PR Context
When passing -UseCulture:$false, the delimiter is not set and the command breaks. Use the default comma delimiter when useCulture is false. Update of solution in PR #26551 by @blanca-negrete. Update to use conditional operator per reviewer feedback.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header