[release/v7.4] Fix PSMethodInvocationConstraints.GetHashCode method#25567
Closed
pwshBot wants to merge 1 commit into
PowerShell:release/v7.4PowerShell/PowerShell:release/v7.4from
pwshBot:backport/release/v7.4/24965-dc84dbca9pwshBot/PowerShell:backport/release/v7.4/24965-dc84dbca9Copy head branch name to clipboard
Closed
[release/v7.4] Fix PSMethodInvocationConstraints.GetHashCode method#25567pwshBot wants to merge 1 commit intoPowerShell:release/v7.4PowerShell/PowerShell:release/v7.4from pwshBot:backport/release/v7.4/24965-dc84dbca9pwshBot/PowerShell:backport/release/v7.4/24965-dc84dbca9Copy head branch name to clipboard
pwshBot wants to merge 1 commit into
PowerShell:release/v7.4PowerShell/PowerShell:release/v7.4from
pwshBot:backport/release/v7.4/24965-dc84dbca9pwshBot/PowerShell:backport/release/v7.4/24965-dc84dbca9Copy head branch name to clipboard
Conversation
There is a difference between GetHashCode for array object itself and cumulative GetHashCode based on hashes of the array members.
Member
|
@PowerShell/powershell-maintainers We don't have a customer impact statement and as stability is paramount for an LTS, we err on the side of not taking this until we have more information. |
Contributor
|
📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24965 to release/v7.4
Triggered by @TravisEz13 on behalf of @crazyjncsu
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
Choose either tooling or Customer impact.
Tooling Impact
Customer Impact
Large amount of memory used in almost every method invocation.
Regression
7.4 - Performance regression.
Testing
No tests changed, because it's a perf issue not a functional issue
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]