Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments#25357

Merged
TravisEz13 merged 3 commits into
PowerShell:release/v7.5PowerShell/PowerShell:release/v7.5from
pwshBot:backport/release/v7.5/25022-7be2e9e8fpwshBot/PowerShell:backport/release/v7.5/25022-7be2e9e8fCopy head branch name to clipboard
Jun 3, 2025
Merged

[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments#25357
TravisEz13 merged 3 commits into
PowerShell:release/v7.5PowerShell/PowerShell:release/v7.5from
pwshBot:backport/release/v7.5/25022-7be2e9e8fpwshBot/PowerShell:backport/release/v7.5/25022-7be2e9e8fCopy head branch name to clipboard

Conversation

@pwshBot

@pwshBot pwshBot commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Backport of #25022 to release/v7.5

Triggered by @TravisEz13 on behalf of @daxian-dbw

Original CL Label: CL-Engine

/cc @PowerShell/powershell-maintainers

Impact

Choose either tooling or Customer impact.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Issue with some parameters to calls not getting logged to AMSI.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

manually tested by turning on the console log

Risk

  • High
  • Medium
  • Low

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

@TravisEz13 TravisEz13 changed the title [release/v7.5]!!!MERGE_CONFLICT!!! Move .NET method invocation logging to after the needed type conversion is done for method arguments [release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments Apr 14, 2025
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 14, 2025
@TravisEz13 TravisEz13 marked this pull request as draft April 14, 2025 22:52

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for 1 issue.

Comment thread src/System.Management.Automation/engine/runtime/Binding/Binders.cs
@TravisEz13 TravisEz13 marked this pull request as ready for review April 15, 2025 20:38
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Apr 22, 2025
@TravisEz13

Copy link
Copy Markdown
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Jun 3, 2025
@TravisEz13 TravisEz13 enabled auto-merge (squash) June 3, 2025 20:07
@TravisEz13 TravisEz13 merged commit bd83cba into PowerShell:release/v7.5 Jun 3, 2025
5 checks passed
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@cole67

cole67 commented Jun 30, 2025

Copy link
Copy Markdown

pwshBot:backport/release/v7.5/25022-7be2e9e8f

@luckykargbo

Copy link
Copy Markdown

yes

@khulekanimbanjwa9-design

Copy link
Copy Markdown

pwshBot:backport/release/v7.5/25022-7be2e9e8f

@Ebaoone Ebaoone left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ebaone

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.5.x-Done CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.