[release/v7.5] Fix up buffer management getting network roots#25311
Closed
pwshBot wants to merge 1 commit into
PowerShell:release/v7.5PowerShell/PowerShell:release/v7.5from
pwshBot:backport/release/v7.5/24600-9418533e8pwshBot/PowerShell:backport/release/v7.5/24600-9418533e8Copy head branch name to clipboard
Closed
[release/v7.5] Fix up buffer management getting network roots#25311pwshBot wants to merge 1 commit intoPowerShell:release/v7.5PowerShell/PowerShell:release/v7.5from pwshBot:backport/release/v7.5/24600-9418533e8pwshBot/PowerShell:backport/release/v7.5/24600-9418533e8Copy head branch name to clipboard
pwshBot wants to merge 1 commit into
PowerShell:release/v7.5PowerShell/PowerShell:release/v7.5from
pwshBot:backport/release/v7.5/24600-9418533e8pwshBot/PowerShell:backport/release/v7.5/24600-9418533e8Copy head branch name to clipboard
Conversation
Fixes the logic used when getting the PSDrive DisplayRoot for network PSDrive paths to exclude null terminators.
Member
|
@jborean93 Can you confirm this backport includes all the code change to address this issue? |
Collaborator
|
Seems to include everything from the PR, if the tests are running and it passes then we should be good. |
Member
|
Without a customer impact statement, we are not backporting this 7.5. Please re-open with a customer impact statement if you disagree. |
Collaborator
|
@TravisEz13 FYI Although the PR is not merged, the original PR has retained the label |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24600 to release/v7.5
Triggered by @TravisEz13 on behalf of @jborean93
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
Choose either tooling or Customer impact.
Tooling Impact
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
?7.4?
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
Since PR mentions that there were multiple attempts fix this issue, the backport might be an incomplete fix
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]