Seal internal type ClientRemoteSessionDSHandlerImpl#24705
Merged
iSazonov merged 2 commits intoDec 25, 2024
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:seal-ClientRemoteSessionDSHandlerImpl2xtqqczze/PowerShell-PowerShell:seal-ClientRemoteSessionDSHandlerImpl2Copy head branch name to clipboard
Merged
Seal internal type ClientRemoteSessionDSHandlerImpl#24705iSazonov merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom xtqqczze:seal-ClientRemoteSessionDSHandlerImpl2xtqqczze/PowerShell-PowerShell:seal-ClientRemoteSessionDSHandlerImpl2Copy head branch name to clipboard
ClientRemoteSessionDSHandlerImpl#24705iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:seal-ClientRemoteSessionDSHandlerImpl2xtqqczze/PowerShell-PowerShell:seal-ClientRemoteSessionDSHandlerImpl2Copy head branch name to clipboard
Conversation
Contributor
Author
|
D:\a\1\s\src\System.Management.Automation\engine\remoting\client\remotingprotocolimplementation.cs(752,24): error CS0628: 'ClientRemoteSessionDSHandlerImpl.Dispose(bool)': new protected member declared in sealed type [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj] |
Contributor
Author
|
@iSazonov checks successful, can we merge? |
iSazonov
approved these changes
Dec 25, 2024
Contributor
|
📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
14 tasks
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #24094.
Seal internal type
System.Management.Automation.Remoting.ClientRemoteSessionDSHandlerImplinsrc/System.Management.Automation/engine/remoting/client/remotingprotocolimplementation.csThe motivation of this PR is this comment by @PaulHigin #11820 (comment).