Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/v7.4] Add a way to use only NuGet feed sources#24542

Merged
TravisEz13 merged 1 commit into
PowerShell:release/v7.4PowerShell/PowerShell:release/v7.4from
TravisEz13:backport-24528TravisEz13/PowerShell:backport-24528Copy head branch name to clipboard
Nov 4, 2024
Merged

[release/v7.4] Add a way to use only NuGet feed sources#24542
TravisEz13 merged 1 commit into
PowerShell:release/v7.4PowerShell/PowerShell:release/v7.4from
TravisEz13:backport-24528TravisEz13/PowerShell:backport-24528Copy head branch name to clipboard

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

Backport #24528

This pull request includes updates to the build.psm1 file to add a new source option and various configuration files to update package source URLs. Additionally, there are improvements to the tools/findMissingNotices.ps1 script to handle missing registrations and version conversion.

Updates to build.psm1:

  • Added NuGetOnly to the ValidateSet for the $Source parameter in the Switch-PSNugetConfig function.
  • Updated the Switch-PSNugetConfig function to handle the new NuGetOnly source option.

Configuration updates:

  • Updated the package source URL in nuget.config to use the new PowerShell URL.
  • Updated the package source URL in src/Modules/nuget.config to use the new PowerShell URL.
  • Updated the package source URL in test/tools/Modules/nuget.config to use the new PowerShell URL.

Improvements to tools/findMissingNotices.ps1:

  • Added a check to ensure that the registration table does not already contain the component name before adding it.
  • Added a new ConvertTo-SemVer function to handle version conversion and edge cases.

* Update build.psm1

* update default feeds

* fix issue with cgmanifest having duplicate existing entries

* update pattern
@TravisEz13 TravisEz13 self-assigned this Nov 4, 2024
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 4, 2024
@TravisEz13
Copy link
Copy Markdown
Member Author

Failures in container tests are because #24543 is not backported yet.

@TravisEz13
Copy link
Copy Markdown
Member Author

Windows CI failure is new, but seems unrelated. Rerunning.

@TravisEz13 TravisEz13 merged commit 72f8c58 into PowerShell:release/v7.4 Nov 4, 2024
@TravisEz13 TravisEz13 deleted the backport-24528 branch November 4, 2024 21:38
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service Bot commented Nov 4, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.