Use lowercase name for package folders#2162
Use lowercase name for package folders#2162
Conversation
.NET CLI build 3546 started placing packages in:
~/.nuget/packages/microsoft.codeanalysis.common
instead of:
~/.nuget/packages/Microsoft.CodeAnalysis.Common
Where the previous (capitalized) version corresponded directly to the
package's name. Now they are all lower-cased.
|
Hi @andschwa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
/cc @vors we need to file issues against .NET CLI and NuGet. These sorts of changes should not happen on a stable branch (we're pinned to .NET CLI rel-1.0.0). 3246 was the last known good .NET CLI version. |
|
Please note that this fix would require everyone to update .NET CLI, due to the behavioral differences of the newer versions. |
|
We could add crap logic to deal with the two possible layouts. |
|
I'd prefer crap logic. It's probably easier then force everybody to update. |
|
Ok, I guess once things will break, people will come here and ask what's going on and update. |
|
Exactly 😄 is our FAQ still a developer FAQ? If so, let's add a note. |
| from y in x.CompileTimeAssemblies where y.Path.EndsWith(".dll") | ||
| // Construct the path to the assemblies | ||
| select $"{context.PackagesDirectory}/{x.Name}/{x.Version}/{y.Path};"); | ||
| select $"{context.PackagesDirectory}/{x.Name.ToLower()}/{x.Version}/{y.Path};"); |
There was a problem hiding this comment.
Is it expected/desired for this to be dependent on the current culture, or should this be ToLowerInvariant?
There was a problem hiding this comment.
@nil4 you right, it's better to use ToLowerInvariant().
.NET CLI build 3546 started placing packages in:
instead of:
Where the previous (capitalized) version corresponded directly to the
package's name. Now they are all lower-cased.