Added tests for hashtabletoPSCustomObjectConversion, OutErrorVairable… by bingbing8 · Pull Request #2160 · PowerShell/PowerShell

bingbing8 · Sep 1, 2016

Added tests for hashtabletoPSCustomObjectConversion, OutErrorVairable. Please review.

… tests.

msftclas · Sep 1, 2016

Hi @bingbing8, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Yanbing Wang). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

msftclas · Sep 2, 2016

Hi @bingbing8, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Yanbing Wang). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

JamesWTruher · Sep 2, 2016

��D�e�s�c�r�i�b�e� �"�T�e�s�t�s� �f�o�r� �h�a�s�h�t�a�b�l�e� �t�o� �P�S�C�u�s�t�o�m�O�b�j�e�c�t� �c�o�n�v�e�r�s�i�o�n�"� �-�T�a�g�s� �"�C�I�"� �{�

this file looks to be the wrong encoding - can you be sure that the BOM is not present and that the file is UTF8 (or ascii) - it's really hard to read

Refers to: test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1:1 in 31f22c6. [](commit_id = 31f22c6, deletion_comment = False)

JamesWTruher · Sep 2, 2016

� � � � � � � � �I�t� �'�$�a� �t�y�p�e�'� �{� �$�a� �-�i�s� �[�S�y�s�t�e�m�.�M�a�n�a�g�e�m�e�n�t�.�A�u�t�o�m�a�t�i�o�n�.�P�S�O�b�j�e�c�t�]� �|� �S�h�o�u�l�d� �B�e� �$�t�r�u�e� �}� � � � � � � � �

this can be

it '$a type' { $a | should BeOfType "System.Management.automation.psobject" }

Refers to: test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1:15 in 31f22c6. [](commit_id = 31f22c6, deletion_comment = False)

JamesWTruher · Sep 2, 2016

�

I don't think we really need a new type here - wouldn't this be ok?

describe "good description here" {
    it "good test name here" {
        try {
            new-object System.Management.Automation.MetadataException -property @{ Source = "foobar"; aa = 1 }
            throw "OK"
        }
        catch {
            $_.Exception | Should BeOfType "InvalidOperationException"
            $_.Exception.Message | Should Match "aa"
            $_.FullyQualifiedErrorId | should be "InvalidOperationException,Microsoft.PowerShell.Commands.NewObjectCommand"
        }
    }
}

Refers to: test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1:66 in 31f22c6. [](commit_id = 31f22c6, deletion_comment = False)

JamesWTruher · Sep 2, 2016

+    }
+
+    Context 'Updating OutVariable Case 1: pipe string' {        
+


These aren't going to do anything because they're not in it blocks, also these really look like they could all be done via test cases

$testcases = @{ Title = "Updating OutVariable Case 1: pipe string"; command = "get-foo1"; OutVariable = "a"; Expected = "foo" }, @{ Title = 'Updating OutVariable Case 2: $pscmdlet.writeobject'; command = "get-foo1"; OutVariable = "a"; Expected = "foo" } Describe Tests { BeforeAll { function get-foo1 { [CmdletBinding()] param() "foo" } function get-foo2 { [CmdletBinding()] param() $pscmdlet.writeobject("foo") } function get-bar { [CmdletBinding()] param() "bar" get-foo1 -outVariable global:a } } It "<Title>" -TestCases $testcases { param ( $command, $arguments, $Expected, $OutVariable ) & $command -OutVariable $OutVariable > $null Get-Variable -ValueOnly $outVariable | should be $Expected } }

fixed

In reply to: 77278055 [](ancestors = 77278055)

bingbing8 · Sep 2, 2016

��D�e�s�c�r�i�b�e� �"�T�e�s�t�s� �f�o�r� �h�a�s�h�t�a�b�l�e� �t�o� �P�S�C�u�s�t�o�m�O�b�j�e�c�t� �c�o�n�v�e�r�s�i�o�n�"� �-�T�a�g�s� �"�C�I�"� �{�

fixed

In reply to: 244248919 [](ancestors = 244248919)

Refers to: test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1:1 in 31f22c6. [](commit_id = 31f22c6, deletion_comment = False)

bingbing8 · Sep 2, 2016

� � � � � � � � �I�t� �'�$�a� �t�y�p�e�'� �{� �$�a� �-�i�s� �[�S�y�s�t�e�m�.�M�a�n�a�g�e�m�e�n�t�.�A�u�t�o�m�a�t�i�o�n�.�P�S�O�b�j�e�c�t�]� �|� �S�h�o�u�l�d� �B�e� �$�t�r�u�e� �}� � � � � � � � �

fixed

In reply to: 244249354 [](ancestors = 244249354)

Refers to: test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1:15 in 31f22c6. [](commit_id = 31f22c6, deletion_comment = False)

bingbing8 · Sep 2, 2016

�

fixed

In reply to: 244251597 [](ancestors = 244251597)

Refers to: test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1:66 in 31f22c6. [](commit_id = 31f22c6, deletion_comment = False)

… o scipt scope.

bingbing8 · Sep 7, 2016

@JamesWTruher I updated the tests based on your feedback. some of the replies don't show in browser. please check out. Thanks!

vors · Sep 8, 2016

Assigning the PR to @JamesWTruher

JamesWTruher · Sep 9, 2016

+
+        It '$a should not be $null' { $script:a | Should Not Be $null }
+        It '$a type' { $script:a | should BeOfType "System.Management.automation.psobject" }
+    }


it seems that this is much too complicated, can't it just be:

It 'New-Object cmdlet should accept empty hashtable or $null as Property argument' { $a = new-object psobject -property $a | should not BeNullOrEmpty $a | should BeOfType "System.Management.Automation.PSObject" }

I don't see the point of the extra it statements, if the first line throws the test will fail

fixed.

In reply to: 78253881 [](ancestors = 78253881)

JamesWTruher · Sep 9, 2016

bingbing8 · Sep 12, 2016

@JamesWTruher Thanks for your feedback. I addressed all of them. Please check.

JamesWTruher · Sep 12, 2016

vors · Sep 12, 2016

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8" standalone="no"?>


please, remove this file from the PR.
In #2182 @douglaswth added it to ,gitignore.

Particularly because this file contains env-specific line

<NuGetPackageRoot>C:\git\part4\Packages</NuGetPackageRoot>

@sergei Vorobev good catch. I removed the file. Thanks!

In reply to: 78430315 [](ancestors = 78430315)

vors · Sep 12, 2016

🕐

Added tests for hashtabletoPSCustomObjectConversion, OutErrorVairable…

96ff914

… tests.

msftclas added the cla-not-required label Sep 1, 2016

Update the title of hashtable to PSCustomObject conversion.

31f22c6

TravisEz13 added the Review - Needed label Sep 2, 2016

vors closed this Sep 2, 2016

vors reopened this Sep 2, 2016

msftclas added the cla-not-required label Sep 2, 2016

JamesWTruher reviewed Sep 2, 2016
View reviewed changes

daxian-dbw added Review - Waiting on Author and removed Review - Needed labels Sep 2, 2016

TravisEz13 added Review - Needed and removed Review - Waiting on Author labels Sep 2, 2016

bingbing8 added 9 commits September 2, 2016 18:43

Update based on PR feedback

40ad73b

updated more cases using testcase

0d8f3f9

update the format of the array

17a518b

Update to investigate an failure only happy in CI system

58486a7

update one test in OutErrorVariable

daf1bf7

update a test title

3895779

Fixed tests which has impact on other tests

71feca8

remove line to clean up the global variable since it has been changed…

ea5cb25

… o scipt scope.

Removed two lines for debugging purpuse

650c73a

vors assigned JamesWTruher Sep 8, 2016

JamesWTruher reviewed Sep 9, 2016
View reviewed changes

Updated based on Jim's feedback.

ae43dae

vors reviewed Sep 12, 2016
View reviewed changes

vors assigned vors and unassigned JamesWTruher Sep 12, 2016

vors added Review - Waiting on Author and removed Review - Needed labels Sep 12, 2016

bingbing8 added 2 commits September 12, 2016 13:40

remove file csharp.nuget.props from the PR. It was added by mistake.

4e54e84

added new lines at the end of the files.

08758ca

TravisEz13 added Review - Needed and removed Review - Waiting on Author labels Sep 12, 2016

vors merged commit fd4552b into PowerShell:master Sep 13, 2016

		@@ -0,0 +1,10 @@
		<?xml version="1.0" encoding="utf-8" standalone="no"?>

Search code, repositories, users, issues, pull requests...

Conversation

bingbing8 commented Sep 1, 2016

Uh oh!

msftclas commented Sep 1, 2016

Uh oh!

msftclas commented Sep 2, 2016

Uh oh!

JamesWTruher commented Sep 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamesWTruher commented Sep 2, 2016

Uh oh!

JamesWTruher commented Sep 2, 2016

Uh oh!

JamesWTruher Sep 2, 2016

Choose a reason for hiding this comment

Uh oh!

bingbing8 Sep 3, 2016

Choose a reason for hiding this comment

Uh oh!

bingbing8 commented Sep 2, 2016

Uh oh!

bingbing8 commented Sep 2, 2016

Uh oh!

bingbing8 commented Sep 2, 2016

Uh oh!

bingbing8 commented Sep 7, 2016

Uh oh!

vors commented Sep 8, 2016

Uh oh!

JamesWTruher Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

bingbing8 Sep 11, 2016

Choose a reason for hiding this comment

Uh oh!

JamesWTruher commented Sep 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bingbing8 commented Sep 12, 2016

Uh oh!

JamesWTruher commented Sep 12, 2016

Uh oh!

vors Sep 12, 2016

Choose a reason for hiding this comment

Uh oh!

bingbing8 Sep 12, 2016

Choose a reason for hiding this comment

Uh oh!

vors commented Sep 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JamesWTruher commented Sep 2, 2016 •

edited

Loading

JamesWTruher commented Sep 9, 2016 •

edited

Loading