Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: typo donet -> dotnet#20122

Merged
adityapatwardhan merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
0o001:master0o001/PowerShell:masterCopy head branch name to clipboard
Aug 29, 2023
Merged

fix: typo donet -> dotnet#20122
adityapatwardhan merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
0o001:master0o001/PowerShell:masterCopy head branch name to clipboard

Conversation

@0o001

@0o001 0o001 commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 76 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +38 -38
Percentile : 30.4%

Total files changed: 13

Change summary by file extension:
.psm1 : +2 -2
.yml : +36 -36

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Comment thread build.psm1
Comment on lines +22 to +23
$dotnetAzureFeed = if (-not $env:__DOTNET_RUNTIME_FEED ) { $dotnetMetadata.Sdk.azureFeed }
$dotnetAzureFeedSecret = $env:__DOTNET_RUNTIME_FEED_KEY

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those env variables internal-only? Could this change possibly break workflow of someone who used the mistyped variables?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what I've observed, they seem to be internal-only, but it might be prudent for others to conduct a review.

@daxian-dbw

Copy link
Copy Markdown
Member

@adityapatwardhan can you please review the environment variable names?

@adityapatwardhan

Copy link
Copy Markdown
Member

I will double check the variable names and confirm if the infrastructure pipelines have the same typo.. I can update them their too.

@adityapatwardhan

Copy link
Copy Markdown
Member

this change should not cause any breaks in the release pipeline.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Aug 28, 2023
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

1 similar comment
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan merged commit 6df26a3 into PowerShell:master Aug 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Aug 29, 2023
@adityapatwardhan adityapatwardhan added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.4.x-Consider labels Aug 29, 2023
daxian-dbw added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.