Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move build to .NET 8 preview 6#19991

Merged
adityapatwardhan merged 12 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:dotnet8-preview6SteveL-MSFT/PowerShell:dotnet8-preview6Copy head branch name to clipboard
Aug 7, 2023
Merged

Move build to .NET 8 preview 6#19991
adityapatwardhan merged 12 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:dotnet8-preview6SteveL-MSFT/PowerShell:dotnet8-preview6Copy head branch name to clipboard

Conversation

@SteveL-MSFT

@SteveL-MSFT SteveL-MSFT commented Jul 17, 2023

Copy link
Copy Markdown
Member

PR Summary

Errors were from additional method analysis that methods not using instance data should be marked as static. Addressed all the reported errors.

Constructor for a marshaled type has to be public due to breaking change in .NET 8.

Needed to rev isolation test module to use 13.0.0.1 of NewtonSoft as anything older gets flagged due to a security issue. Changed test to check file location instead of version.

Removed win-arm build as some assemblies for .NET 8 don't appear to be published for win-arm anymore since .NET dropped support for it.

PR Context

Moving to .NET 8 preview 6

PR Checklist

Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs Outdated
daxian-dbw
daxian-dbw previously approved these changes Jul 17, 2023

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread test/powershell/engine/Module/IsolatedModule.Tests.ps1 Outdated
@SteveL-MSFT

Copy link
Copy Markdown
Member Author

The Windows xunit test issue is a known issue with MMI.dll and .NET 8 newer previews. I believe @adityapatwardhan has a workaround.

Comment thread test/powershell/engine/Module/IsolatedModule.Tests.ps1 Outdated
@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Jul 24, 2023

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked at changes

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

2 similar comments
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Comment thread test/powershell/engine/Module/IsolatedModule.Tests.ps1 Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Aug 7, 2023
@adityapatwardhan

Copy link
Copy Markdown
Member

@SteveL-MSFT - please look at CI failures

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 74 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +27 -47
Percentile : 29.6%

Total files changed: 19

Change summary by file extension:
.yml : +0 -15
.json : +1 -1
.cs : +24 -30
.csproj : +2 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 7, 2023
@adityapatwardhan adityapatwardhan enabled auto-merge (squash) August 7, 2023 21:16
@adityapatwardhan adityapatwardhan merged commit e97105b into PowerShell:master Aug 7, 2023
@SteveL-MSFT SteveL-MSFT deleted the dotnet8-preview6 branch August 7, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.