SetLastError as true for Symbolic and Hard Link native APIs#19566
Merged
daxian-dbw merged 1 commit intoMay 1, 2023
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FixSetLastErroradityapatwardhan/PowerShell:FixSetLastErrorCopy head branch name to clipboard
Merged
SetLastError as true for Symbolic and Hard Link native APIs#19566daxian-dbw merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:FixSetLastErroradityapatwardhan/PowerShell:FixSetLastErrorCopy head branch name to clipboard
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FixSetLastErroradityapatwardhan/PowerShell:FixSetLastErrorCopy head branch name to clipboard
Conversation
JamesWTruher
approved these changes
Apr 25, 2023
Collaborator
|
Could you please point a code where we use the last error? I don't see using GetLastWin32Error/GetLastError. |
Contributor
Yeah it's called here |
iSazonov
approved these changes
Apr 26, 2023
SteveL-MSFT
approved these changes
May 1, 2023
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Ensure the native PInvoke call has SetLastError in the LibraryImport attribuute. We use the last error to determine the correct fully qualified error id.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).