Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix test failures on Windows for time zone and remoting#19466

Merged
adityapatwardhan merged 7 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FixWinTestsadityapatwardhan/PowerShell:FixWinTestsCopy head branch name to clipboard
Apr 25, 2023
Merged

Fix test failures on Windows for time zone and remoting#19466
adityapatwardhan merged 7 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FixWinTestsadityapatwardhan/PowerShell:FixWinTestsCopy head branch name to clipboard

Conversation

@adityapatwardhan

Copy link
Copy Markdown
Member

PR Summary

  • Fix test on Windows client where -SkipNetworkProfile check is needed.
  • Make Test-IsWinServer2012R2 a common help function and skip time zone tests correctly.

PR Context

PR Checklist

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 15, 2023
@ghost

ghost commented Apr 15, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan

Copy link
Copy Markdown
Member Author

@anmenaga - can you please review?

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 24, 2023
@adityapatwardhan adityapatwardhan merged commit cf6fc53 into PowerShell:master Apr 25, 2023
@adityapatwardhan adityapatwardhan deleted the FixWinTests branch April 25, 2023 18:06
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 28, 2023
@ghost

ghost commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.