Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove FormObject.cs and FormObjectCollection.cs#19383

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
CarloToso:remove-formobjectCarloToso/PowerShell:remove-formobjectCopy head branch name to clipboard
Mar 21, 2023
Merged

Remove FormObject.cs and FormObjectCollection.cs#19383
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
CarloToso:remove-formobjectCarloToso/PowerShell:remove-formobjectCopy head branch name to clipboard

Conversation

@CarloToso

@CarloToso CarloToso commented Mar 21, 2023 •
edited by iSazonov
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Update: reverted in #19387

Remove dead code:

  • FormObject.cs
  • FormObjectCollaction.cs

PR Context

Discussed with @iSazonov in #19359

PR Checklist

@CarloToso CarloToso requested a review from PaulHigin as a code owner March 21, 2023 17:23
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 21, 2023

Copy link
Copy Markdown

This PR has 30 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +0 -30
Percentile : 12%

Total files changed: 3

Change summary by file extension:
.cs : +0 -30

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Mar 21, 2023
@iSazonov iSazonov changed the title WebCmdlets remove form object Remove FormObject.cs and FormObjectCollaction.cs Mar 21, 2023
@CarloToso CarloToso changed the title Remove FormObject.cs and FormObjectCollaction.cs Remove FormObject.cs and FormObjectCollection.cs Mar 21, 2023
@iSazonov iSazonov merged commit 190c99a into PowerShell:master Mar 21, 2023
@daxian-dbw

daxian-dbw commented Mar 21, 2023

Copy link
Copy Markdown
Member

@iSazonov and @CarloToso, FormObject and FormObjectCollaction are public types, and thus it's possible to call Invoke-WebRequest -Body with a FormObject instance, isn't it? This change looks like a regression.

@iSazonov

iSazonov commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

@daxian-dbw Thanks for pointer this! I missed that fact. @CarloToso Please revert of the commit.
Although this class is useless I guess since there is an option for IDIctionary afterwards.
Maybe we should think about removing this class and mark it now as obsolete? @daxian-dbw What do you think?

@iSazonov

iSazonov commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

@CarloToso Please revert the commit.

CarloToso added a commit to CarloToso/PowerShell that referenced this pull request Mar 22, 2023
@CarloToso
Revert "Remove FormObject.cs and FormObjectCollection.cs (PowerShell#…
cf74cde 
…19383)"

This reverts commit 190c99a.
@CarloToso CarloToso mentioned this pull request Mar 22, 2023
Merged
@iSazonov iSazonov added CL-NotInBuild Indicates that a PR is reverted and not part of the build. and removed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Mar 22, 2023
@daxian-dbw

daxian-dbw commented Mar 22, 2023

Copy link
Copy Markdown
Member

I don't have a strong opinion. I guess we should just keep it as is, since there is no real reason to remove it.

iSazonov pushed a commit that referenced this pull request Mar 22, 2023
@CarloToso
Revert "Remove FormObject.cs and FormObjectCollection.cs (#19383)" (#…
098be48 
…19387)

This reverts commit 190c99a.
@CarloToso CarloToso deleted the remove-formobject branch March 22, 2023 20:04
CarloToso pushed a commit to CarloToso/PowerShell that referenced this pull request Apr 8, 2023
@stevenebutler
Pr/19379 (#1)
1a6707d 
* Remove FormObject.cs and FormObjectCollection.cs (PowerShell#19383)

* Exclude redundant parameter aliases from completion results (PowerShell#19382)

* Revert "Remove FormObject.cs and FormObjectCollection.cs (PowerShell#19383)" (PowerShell#19387)

This reverts commit 190c99a.

* Add the parameter `-RelativeBasePath` to `Resolve-Path` (PowerShell#19358)

* Fix a crash in the type inference code (PowerShell#19400)

* Remove GetResponseObject (PowerShell#19380)

* Add `-Environment` parameter to `Start-Process` (PowerShell#19374)

* Add `-Environment` parameter to `Start-Process`

* address codefactor

* fix test for Windows

* handle case where value is $null to remove env var

* change variables to make it more clear what the test is doing

* Add PoolNames variable group to compliance pipeline (PowerShell#19408)

* Improve package management acceptance tests by not going to the gallery (PowerShell#19412)

* Skip VT100 tests on Windows Server 2012R2 as console does not support it (PowerShell#19413)

* Update the `ICommandPredictor` interface to reduce boilerplate code from predictor implementation (PowerShell#19414)

* Enable type conversion of `AutomationNull` to `$null` for assignment (PowerShell#19415)

* Remove code related to `#requires -pssnapin` (PowerShell#19320)

* Support CTRL-C when reading data and connection hangs for `Invoke-RestMethod` and `Invoke-WebRequest` (PowerShell#19330)

* Update to the latest NOTICES file (PowerShell#19332)

* Update the cgmanifest (PowerShell#19459)

* WIP: Harden default command test. (PowerShell#19416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build. Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarloToso @daxian-dbw @iSazonov @adityapatwardhan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.