Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix using xml -Body in webcmdlets without an encoding#19281

Merged
iSazonov merged 7 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
CarloToso:fix-bug-xmlCarloToso/PowerShell:fix-bug-xmlCopy head branch name to clipboard
Mar 7, 2023
Merged

Fix using xml -Body in webcmdlets without an encoding#19281
iSazonov merged 7 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
CarloToso:fix-bug-xmlCarloToso/PowerShell:fix-bug-xmlCopy head branch name to clipboard

Conversation

@CarloToso

@CarloToso CarloToso commented Mar 5, 2023 •
edited by iSazonov
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Allow using xml -Body in webcmdlets without an encoding

PR Context

fix #19280

PR Checklist

@CarloToso CarloToso requested a review from PaulHigin as a code owner March 5, 2023 21:34
@ghost ghost assigned daxian-dbw Mar 5, 2023
@iSazonov iSazonov changed the title Invoke-WebRequest fix bug xml Fix using xml -Body in webcmdlets without an encoding Mar 6, 2023
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 6, 2023
iSazonov
iSazonov reviewed Mar 6, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated
iSazonov
iSazonov reviewed Mar 6, 2023
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated
CarloToso and others added 2 commits March 6, 2023 17:46
@CarloToso @iSazonov
Update test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlet…
3370f1f 
…s.Tests.ps1

Co-authored-by: Ilya <darpa@yandex.ru>
@CarloToso @iSazonov
Update test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlet…
9e7bef1 
…s.Tests.ps1

Co-authored-by: Ilya <darpa@yandex.ru>
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 6, 2023

Copy link
Copy Markdown

This PR has 13 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +12 -1
Percentile : 5.2%

Total files changed: 2

Change summary by file extension:
.cs : +1 -1
.ps1 : +11 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

1 similar comment
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 6, 2023

Copy link
Copy Markdown

This PR has 13 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +12 -1
Percentile : 5.2%

Total files changed: 2

Change summary by file extension:
.cs : +1 -1
.ps1 : +11 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Mar 7, 2023
@iSazonov iSazonov merged commit 6824d48 into PowerShell:master Mar 7, 2023
@CarloToso CarloToso deleted the fix-bug-xml branch March 7, 2023 18:44
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 14, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invoke-WebRequest / Invoke-RestMethod fail with an [xml] -Body argument if the document has an XML declaration but no "encoding" attribute.

4 participants

@CarloToso @SteveL-MSFT @iSazonov @daxian-dbw
Morty Proxy This is a proxified and sanitized view of the page, visit original site.