Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add URL for all distributions#19159

Merged
TravisEz13 merged 2 commits into
masterPowerShell/PowerShell:masterfrom
Add-PMC-urlPowerShell/PowerShell:Add-PMC-urlCopy head branch name to clipboard
Feb 16, 2023
Merged

Add URL for all distributions#19159
TravisEz13 merged 2 commits into
masterPowerShell/PowerShell:masterfrom
Add-PMC-urlPowerShell/PowerShell:Add-PMC-urlCopy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented Feb 15, 2023

Copy link
Copy Markdown
Member

PR Summary

  • Add URL for all distributions
    • The URL will be required in the future

PR Context

PR Checklist

@ghost ghost assigned PaulHigin Feb 15, 2023
@TravisEz13 TravisEz13 added BackPort-7.0.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Feb 15, 2023
@TravisEz13 TravisEz13 marked this pull request as ready for review February 15, 2023 21:29
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 79 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +55 -24
Percentile : 31.6%

Total files changed: 1

Change summary by file extension:
.json : +55 -24

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit 27313be into master Feb 16, 2023
@TravisEz13 TravisEz13 deleted the Add-PMC-url branch February 16, 2023 23:23
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Apr 12, 2023
* Add URL for all distributions

* Make url compatible
@ghost

ghost commented Apr 13, 2023

Copy link
Copy Markdown

🎉v7.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Apr 13, 2023

Copy link
Copy Markdown

🎉v7.3.4 has been released which incorporates this pull request.:tada:

Handy links:

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 25, 2023
* Add URL for all distributions

* Make url compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.