Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix redirection for -CustomMethod "POST" in WebCmdlets#19111

Merged
iSazonov merged 10 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
CarloToso:Fix-Bug-CustomMethod-handleredirectCarloToso/PowerShell:Fix-Bug-CustomMethod-handleredirectCopy head branch name to clipboard
Feb 10, 2023
Merged

Fix redirection for -CustomMethod "POST" in WebCmdlets#19111
iSazonov merged 10 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
CarloToso:Fix-Bug-CustomMethod-handleredirectCarloToso/PowerShell:Fix-Bug-CustomMethod-handleredirectCopy head branch name to clipboard

Conversation

@CarloToso

@CarloToso CarloToso commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

PR Summary

  • If we get to this point with -CustomMethod "POST", we don't use IsRedirectToGet because we only check for Method == WebRequestMethod.Post
    --> checking for req.Method == HttpMethod.Post solves this but:

  • setting Method = WebRequestMethod.Get would be ignored by HttpMethod httpMethod = string.IsNullOrEmpty(CustomMethod) ? GetHttpMethod(Method) : new HttpMethod(CustomMethod) (in GetResponse line 1230)
    --> solved by setting CustomMethod = string.Empty

PR Context

Fix bug discussed in #18894 @iSazonov, merge before #18894

PR Checklist

@CarloToso CarloToso requested a review from PaulHigin as a code owner February 7, 2023 11:32
@ghost ghost assigned adityapatwardhan Feb 7, 2023
@CarloToso CarloToso changed the title Fix 2 Bugs Fix 2 Bugs with CustomMethod and IsRedirectToGet Feb 7, 2023
@iSazonov iSazonov changed the title Fix 2 Bugs with CustomMethod and IsRedirectToGet Add support redirection for -CustomMethod "POST" in WebCmdlets Feb 7, 2023
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 7, 2023

@iSazonov iSazonov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you please check that new tests don't work with 7.3?

@CarloToso

Copy link
Copy Markdown
Contributor Author

@iSazonov I confirm the new test fails in PS7.3.2
Cattura2

@iSazonov iSazonov changed the title Add support redirection for -CustomMethod "POST" in WebCmdlets Fix redirection for -CustomMethod "POST" in WebCmdlets Feb 8, 2023
@iSazonov

iSazonov commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

@CarloToso Please resolve merge conflict.

@CarloToso

Copy link
Copy Markdown
Contributor Author

Resolved merge conflict

@CarloToso

Copy link
Copy Markdown
Contributor Author

Unrelated error

@iSazonov iSazonov closed this Feb 8, 2023
@iSazonov iSazonov reopened this Feb 8, 2023
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 50 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +40 -10
Percentile : 20%

Total files changed: 2

Change summary by file extension:
.cs : +8 -7
.ps1 : +32 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov merged commit ed68c86 into PowerShell:master Feb 10, 2023
@CarloToso CarloToso deleted the Fix-Bug-CustomMethod-handleredirect branch February 10, 2023 11:15
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.