Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update to the latest NOTICES file#19086

Merged
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
update-cgmanifestPowerShell/PowerShell:update-cgmanifestCopy head branch name to clipboard
Feb 13, 2023
Merged

Update to the latest NOTICES file#19086
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
update-cgmanifestPowerShell/PowerShell:update-cgmanifestCopy head branch name to clipboard

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Automated changes by create-pull-request GitHub action

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding update

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 2, 2023
@TravisEz13

Copy link
Copy Markdown
Member

I ran ./tools/clearlyDefined/ClearlyDefined.ps1 -Harvest to resolve this issue.

@github-actions github-actions Bot requested a review from TravisEz13 February 3, 2023 13:07
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 3, 2023
@github-actions github-actions Bot force-pushed the update-cgmanifest branch 3 times, most recently from f4b8566 to 073f5a8 Compare February 9, 2023 13:08
@github-actions github-actions Bot force-pushed the update-cgmanifest branch 2 times, most recently from ada9fde to 46dd625 Compare February 11, 2023 13:07
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +2 -2
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.txt : +2 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit 43abbc4 into master Feb 13, 2023
@TravisEz13 TravisEz13 deleted the update-cgmanifest branch February 13, 2023 20:04
@adityapatwardhan adityapatwardhan added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log and removed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Mar 14, 2023
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.