Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add Windows ARM64 CI#19040

Merged
TravisEz13 merged 31 commits into
masterPowerShell/PowerShell:masterfrom
CIwinArm64PowerShell/PowerShell:CIwinArm64Copy head branch name to clipboard
Jan 31, 2023
Merged

Add Windows ARM64 CI#19040
TravisEz13 merged 31 commits into
masterPowerShell/PowerShell:masterfrom
CIwinArm64PowerShell/PowerShell:CIwinArm64Copy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented Jan 27, 2023

Copy link
Copy Markdown
Member

PR Summary

The goal here is to get Windows ARM64 tests running daily rather than only with a release.

  • Add an Windows ARM64 CI
    • the PR tests will require using /azp run see comment
    • Several templates had to be update to choose between running in an Microsoft Hosted pool or an internal hosted pool
    • Many tests were skipped or pended because of failures. We should try to fix those issues later.

Issues filed:

PR Context

PR Checklist

@TravisEz13

Copy link
Copy Markdown
Member Author

/azp run ps-Windows-Arm64

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13 TravisEz13 marked this pull request as ready for review January 27, 2023 21:03
Comment thread .vsts-ci/templates/ci-build.yml Outdated
Comment thread .vsts-ci/templates/ci-build.yml Outdated
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1 Outdated
Comment thread test/powershell/Host/ScreenReader.Tests.ps1 Outdated

@kilasuit kilasuit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor codefactor issues & minor other little nitpicks I am very glad to see this.

Comment thread test/powershell/Host/ScreenReader.Tests.ps1 Outdated
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
Comment thread test/powershell/engine/ExperimentalFeature/Get-ExperimentalFeature.Tests.ps1 Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 28, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 31, 2023
@TravisEz13

Copy link
Copy Markdown
Member Author

/azp run ps-Windows-Arm64

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 271 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +246 -25
Percentile : 67.1%

Total files changed: 31

Change summary by file extension:
.yml : +143 -5
.psm1 : +13 -3
.ps1 : +85 -13
.psd1 : +5 -4

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit b2c4888 into master Jan 31, 2023
@TravisEz13 TravisEz13 deleted the CIwinArm64 branch January 31, 2023 20:06
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Mar 14, 2023
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.