Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix regression in RemoveNulls#18881

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:input-containsiSazonov/PowerShell:input-containsCopy head branch name to clipboard
Jan 10, 2023
Merged

Fix regression in RemoveNulls#18881
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:input-containsiSazonov/PowerShell:input-containsCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Jan 3, 2023

Copy link
Copy Markdown
Collaborator

PR Summary

Fix regression after #11884.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 3, 2023
@iSazonov iSazonov requested a review from SteveL-MSFT January 3, 2023 17:08
@iSazonov iSazonov requested a review from daxian-dbw as a code owner January 3, 2023 17:08
@iSazonov iSazonov self-assigned this Jan 3, 2023
@iSazonov iSazonov requested a review from anmenaga as a code owner January 3, 2023 17:08
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +2 -2
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.cs : +2 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that could be added?

@iSazonov

iSazonov commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator Author

Is there a test that could be added?

I don't understand how the nulls could appear. Perhaps it is internals of the Windows API. Then there is no chance of creating a test. 😕
Perhaps it is a dead code since we have not seen problems for a long time.

@SteveL-MSFT

Copy link
Copy Markdown
Member

This code appears to only be used with the built in ReadLine and not when PSReadLine is used. I suspect it's to handle the case of cut & paste where the content includes nulls. Given that this code is likely not used often (as most folks are using the default PSReadLine), I wouldn't spend time adding a test then.

@iSazonov iSazonov merged commit 046c8d4 into PowerShell:master Jan 10, 2023
@iSazonov iSazonov deleted the input-contains branch January 10, 2023 02:38
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.