Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Libraryimport hcs#18768

Closed
iSazonov wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:libraryimport-hcsiSazonov/PowerShell:libraryimport-hcsCopy head branch name to clipboard
Closed

Libraryimport hcs#18768
iSazonov wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:libraryimport-hcsiSazonov/PowerShell:libraryimport-hcsCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Contributes to #18553.

Continue #18194.

I wonder we did not exclude Windows code from Unix...

The new HCS API is natively async and we could use async/await if needed. Example https://github.com/dantmnf/WSLAttachSwitch/blob/f3d9c0a85214c61f04c06ea42f7a1ce79b460a17/ComputeService/HcsOperation.cs

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 12, 2022
@iSazonov iSazonov requested a review from SteveL-MSFT December 12, 2022 11:00
xtqqczze
xtqqczze reviewed Dec 13, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs
[DllImport(PinvokeDllNames.CreateProcessInComputeSystemDllName, SetLastError = true, CharSet = CharSet.Unicode)]
internal static extern uint HcsOpenComputeSystem(
string id,
ref IntPtr computeSystem,

@xtqqczze xtqqczze Dec 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why IntPtr is passed by-ref?

@iSazonov iSazonov Dec 13, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is old broken code, please ignore.

@xtqqczze

xtqqczze commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

@iSazonov There is a style issue: IntPtr ComputeSystem -> IntPtr computeSystem that could be confusing for reviewers.

You could cherry-pick 4dda94d, or I can submit it as a separate PR.

@iSazonov

iSazonov commented Dec 13, 2022

Copy link
Copy Markdown
Collaborator Author

@iSazonov There is a style issue: IntPtr ComputeSystem -> IntPtr computeSystem that could be confusing for reviewers.

You could cherry-pick 4dda94d, or I can submit it as a separate PR.

Sorry, I don't understand.

@xtqqczze

xtqqczze commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Sorry, I don't understand.

The local variable naming should use camelCase, not PascalCase, otherwise it looks like a member.

@iSazonov

iSazonov commented Dec 13, 2022

Copy link
Copy Markdown
Collaborator Author

Sorry, I don't understand.

The local variable naming should use camelCase, not PascalCase, otherwise it looks like a member.

It is old code. I have only updated pinvoke code for HcsOpenComputeSystem without cleanups.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 16, 2022
@ghost ghost added the Stale label Dec 31, 2022
@ghost

ghost commented Dec 31, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jan 11, 2023
@daxian-dbw daxian-dbw reopened this Jan 11, 2023
@ghost ghost removed the Stale label Jan 11, 2023
@daxian-dbw daxian-dbw removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 11, 2023
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 14, 2023
@ghost ghost added the Stale label Jan 29, 2023
@ghost

ghost commented Jan 29, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Feb 8, 2023
@iSazonov iSazonov reopened this Feb 8, 2023
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Feb 8, 2023
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Feb 8, 2023

Copy link
Copy Markdown

This PR has 82 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Small
Size       : +70 -12
Percentile : 32.8%

Total files changed: 9

Change summary by file extension:
.cs : +70 -12

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 11, 2023
@ghost ghost added the Stale label Feb 26, 2023
@ghost

ghost commented Feb 26, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Mar 9, 2023
@iSazonov iSazonov mentioned this pull request Mar 16, 2023
Closed
5 tasks
@iSazonov iSazonov deleted the libraryimport-hcs branch March 20, 2026 12:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw will be requested when the pull request is marked ready for review daxian-dbw is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 will be requested when the pull request is marked ready for review TravisEz13 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Small Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iSazonov @xtqqczze @daxian-dbw
Morty Proxy This is a proxified and sanitized view of the page, visit original site.