Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Create tasks to collect and publish hashes for build files.#18276

Merged
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
JamesWTruher:CreateHashForReleaseJamesWTruher/PowerShell-1:CreateHashForReleaseCopy head branch name to clipboard
Oct 13, 2022
Merged

Create tasks to collect and publish hashes for build files.#18276
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
JamesWTruher:CreateHashForReleaseJamesWTruher/PowerShell-1:CreateHashForReleaseCopy head branch name to clipboard

Conversation

@JamesWTruher

@JamesWTruher JamesWTruher commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

PR Summary

create a csv file containing the hashes and file versions for our build files

PR Context

PR Checklist

@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Oct 13, 2022

Copy link
Copy Markdown

This PR has 14 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +14 -0
Percentile : 5.6%

Total files changed: 1

Change summary by file extension:
.yml : +14 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned TravisEz13 Oct 13, 2022
@TravisEz13 TravisEz13 merged commit 33bbe7d into PowerShell:master Oct 13, 2022
@TravisEz13 TravisEz13 added Backport-7.3.x-Approved Compliance Related to compliance requirements labels Oct 13, 2022
@TravisEz13

TravisEz13 commented Oct 13, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.3.0-rc.1

@github-actions

github-actions Bot commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

@TravisEz13 backporting to release/v7.3.0-rc.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Create tasks to collect and publish hashes for build files.
Using index info to reconstruct a base tree...
A	tools/releaseBuild/azureDevOps/templates/compliance/apiscan.yml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): tools/releaseBuild/azureDevOps/templates/compliance/apiscan.yml deleted in HEAD and modified in Create tasks to collect and publish hashes for build files.. Version Create tasks to collect and publish hashes for build files. of tools/releaseBuild/azureDevOps/templates/compliance/apiscan.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Create tasks to collect and publish hashes for build files.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@JamesWTruher JamesWTruher mentioned this pull request Oct 13, 2022
Merged
22 tasks
@TravisEz13

TravisEz13 commented Oct 13, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.3.0-rc.1

@github-actions github-actions Bot mentioned this pull request Oct 13, 2022
Merged
1 task
@ghost

ghost commented Oct 26, 2022

Copy link
Copy Markdown

🎉v7.3.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 20, 2022
@ghost

ghost commented Dec 20, 2022

Copy link
Copy Markdown

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@TravisEz13 TravisEz13

Labels

Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Compliance Related to compliance requirements Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesWTruher @TravisEz13 @adityapatwardhan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.