Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Set-Clipboard -AsOSC52#18222

Merged
TravisEz13 merged 4 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
dkaszews:dkaszews-set-clipboard-remoteCopy head branch name to clipboard
May 1, 2023
Merged

Set-Clipboard -AsOSC52#18222
TravisEz13 merged 4 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
dkaszews:dkaszews-set-clipboard-remoteCopy head branch name to clipboard

Conversation

@dkaszews

@dkaszews dkaszews commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Add -AsOSC52 switch to Set-Clipboard

PR Context

Closes #18116

PR Checklist

@iSazonov iSazonov requested a review from SteveL-MSFT October 6, 2022 06:58
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 6, 2022
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 10, 2022
@dkaszews dkaszews requested review from SteveL-MSFT and removed request for adityapatwardhan and daxian-dbw October 10, 2022 19:53

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT added the Hacktoberfest-Accepted Accepted to participate in Hacktoberfest label Oct 10, 2022
@dkaszews

Copy link
Copy Markdown
Contributor Author

Failures in Windows CI do not seem related to the change - they passed before the rename suggested by @SteveL-MSFT

@iSazonov

Copy link
Copy Markdown
Collaborator

I restarted Windows-CI.

@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Oct 11, 2022
@iSazonov

Copy link
Copy Markdown
Collaborator

@dkaszews Please create new issue in Docs repository and add reference to it in the PR check list.

@dkaszews

Copy link
Copy Markdown
Contributor Author

@iSazonov Done

@iSazonov iSazonov removed the Documentation Needed in this repo Documentation is needed in this repo label Oct 11, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 19, 2022
@ghost

ghost commented Oct 19, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

@dkaszews

Copy link
Copy Markdown
Contributor Author

@SteveL-MSFT Can you please review? I can remove this -Remote alias as it was my own idea and may be misleading to some, I just would like to get it merged.

@SteveL-MSFT SteveL-MSFT added the WG-Cmdlets general cmdlet issues label Mar 8, 2023
@SteveL-MSFT

Copy link
Copy Markdown
Member

Sorry for the delay, I've queued this up to the Cmdlets WG to discuss

@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 8, 2023
@dkaszews dkaszews changed the title Set-Clipboard -Remote with OSC52 Set-Clipboard -UsingOSC52 Mar 15, 2023
@dkaszews dkaszews changed the title Set-Clipboard -UsingOSC52 Set-Clipboard -AsOSC52 Mar 15, 2023
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 14 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +13 -1
Percentile : 5.6%

Total files changed: 1

Change summary by file extension:
.cs : +13 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost added the Review - Needed The PR is being reviewed label Mar 28, 2023
@ghost

ghost commented Mar 28, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@SteveL-MSFT

Copy link
Copy Markdown
Member

Sorry for the delay, the @PowerShell/wg-powershell-cmdlets agreed on the switch for this so this should be ready to merge given the PR signoffs

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 19, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 27, 2023
@ghost

ghost commented Apr 27, 2023

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@doctordns

Copy link
Copy Markdown
Collaborator

Can this get merged??

@dkaszews

Copy link
Copy Markdown
Contributor Author

Can this get merged??

I'd be happy to know myself, I stopped contributing to PowerShell because of ridiculous review times. It's not the only MR I have stuck in review for over 6 months.

@doctordns

Copy link
Copy Markdown
Collaborator

I have brought this up at the Cmdlet WG and we are happy for this to go ahead. That said, I can not do the merge.

@iSazonov can you merge this PR?

Also - let me know what other PRs you have that are open and if I can, I'll get them in front of the WG next week.

@dkaszews

Copy link
Copy Markdown
Contributor Author

@doctordns Thank you for driving this. For the other two PRs I have open, #18003 fixes white confirm text that is invisible on white background so unsure Cmdlet WG will care. #18037 is more their ballpark as it fixes partial system culture matching in help (e.g. so that en-US is a fallback when en-GB is not available).

@TravisEz13 TravisEz13 merged commit ea68edc into PowerShell:master May 1, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 1, 2023
@sdwheeler sdwheeler added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Jun 1, 2023
@ghost

ghost commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small Hacktoberfest-Accepted Accepted to participate in Hacktoberfest PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed WG-Cmdlets general cmdlet issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set-Clipboard -Remote with OSC52

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.