Remove ApplicationType from Telemetry sends.#18160
Closed
JamesWTruher wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
JamesWTruher:EliminateApplicationTypeTelemetryJamesWTruher/PowerShell-1:EliminateApplicationTypeTelemetryCopy head branch name to clipboard
Closed
Remove ApplicationType from Telemetry sends.#18160JamesWTruher wants to merge 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom JamesWTruher:EliminateApplicationTypeTelemetryJamesWTruher/PowerShell-1:EliminateApplicationTypeTelemetryCopy head branch name to clipboard
JamesWTruher wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
JamesWTruher:EliminateApplicationTypeTelemetryJamesWTruher/PowerShell-1:EliminateApplicationTypeTelemetryCopy head branch name to clipboard
Conversation
This is a minimal change to eliminate telemetry of type ApplicationType it is targeted at previous versions of PowerShell as a minimal change to reduce our incoming telemetry.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Member
|
Superseded by #18168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal change to eliminate telemetry of type ApplicationType it is targeted at previous versions of PowerShell as a minimal change to reduce our incoming telemetry. I would suggest that this be back-ported to our previous releases to reduce the amount of telemetry we ingest.
Eventually, it may be possible to remove ApplicationType as a type of telemetry. However, this is a minimal change for a maximal effect.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).