Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Replace UTF8Encoding(false) with Encoding.Default#18144

Merged
iSazonov merged 4 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:Encoding.Defaultxtqqczze/PowerShell-PowerShell:Encoding.DefaultCopy head branch name to clipboard
Sep 27, 2022
Merged

Replace UTF8Encoding(false) with Encoding.Default#18144
iSazonov merged 4 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:Encoding.Defaultxtqqczze/PowerShell-PowerShell:Encoding.DefaultCopy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

If a statement spans multiple lines, the opening curly bracket must be placed on its own line.
Comment thread src/System.Management.Automation/engine/Utils.cs
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Sep 22, 2022

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall with a minor comment. Thanks for making this change @xtqqczze!

Comment thread src/System.Management.Automation/engine/NativeCommandProcessor.cs
Comment thread src/System.Management.Automation/engine/Utils.cs
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 25, 2022
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 36 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +21 -15
Percentile : 14.4%

Total files changed: 5

Change summary by file extension:
.cs : +21 -15

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 26, 2022
@xtqqczze xtqqczze marked this pull request as ready for review September 26, 2022 22:28
@xtqqczze xtqqczze requested a review from PaulHigin as a code owner September 26, 2022 22:28
@xtqqczze xtqqczze changed the title Use Encoding.Default Replace UTF8Encoding(false) with Encoding.Default Sep 26, 2022
@iSazonov

Copy link
Copy Markdown
Collaborator

@daxian-dbw Can you approve?

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov merged commit fd67038 into PowerShell:master Sep 27, 2022
@iSazonov

Copy link
Copy Markdown
Collaborator

@xtqqczze Thanks!

@ghost

ghost commented Dec 20, 2022

Copy link
Copy Markdown

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.