Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Re-enable tests because the corresponding dotnet issues were fixed#17839

Merged
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:cleanupdaxian-dbw/PowerShell:cleanupCopy head branch name to clipboard
Aug 4, 2022
Merged

Re-enable tests because the corresponding dotnet issues were fixed#17839
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw:cleanupdaxian-dbw/PowerShell:cleanupCopy head branch name to clipboard

Conversation

@daxian-dbw

@daxian-dbw daxian-dbw commented Aug 4, 2022

Copy link
Copy Markdown
Member

PR Summary

Re-enable tests because the corresponding dotnet issues were fixed.

@ghost ghost assigned PaulHigin Aug 4, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Aug 4, 2022

Copy link
Copy Markdown

This PR has 15 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -9
Percentile : 6%

Total files changed: 3

Change summary by file extension:
.ps1 : +6 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw

daxian-dbw commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

Enabling the one in WebCmdlets.Tests.ps1 causes test failure in CIs:

https://dev.azure.com/powershell/PowerShell/_build/results?buildId=105756&view=logs&j=9e4ec56f-654b-5e2a-a49c-90add833d733&t=6b3e4586-9b37-55d5-f4e5-65b1959c196a&l=1846

VERBOSE: Pathological ratio: 0.782796790900782
      [-] Image Parsing 54ms
        Expected the actual value to be greater than 5, but got 0.782796790900782.
        2033:             $pathologicalRatio | Should -BeGreaterThan 5
        at <ScriptBlock>, /Users/runner/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1: line 2033

@vexx32 Can you still recall the context of having this test?

@vexx32

vexx32 commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

Something about the frequency of times it takes to parse the response with the preset regex looking for IMG tags I think. I'm not entirely sure exactly what it was supposed to test or what it was meaning. Maybe @TravisEz13 has a better understanding of it?

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Aug 4, 2022
@daxian-dbw

daxian-dbw commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

@vexx32 Thanks! I will check with @TravisEz13 on this test offline.

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned PaulHigin Aug 4, 2022
@daxian-dbw daxian-dbw merged commit c2323db into PowerShell:master Aug 4, 2022
@daxian-dbw daxian-dbw deleted the cleanup branch August 4, 2022 04:34
@PaulHigin

PaulHigin commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

@daxian-dbw
This test seems to fail about half the time for my CI runs. We should disable this test until it can become more reliable.

@daxian-dbw

daxian-dbw commented Aug 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@PaulHigin which test is failing? The change to "Image Parsing" test in WebCmdlets.Test.ps1 was reverted -- it remains disabled.

@PaulHigin

PaulHigin commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

The webcmdlets test where the pathological number should be in a certain range. I restarted tests a number of times to get it pass after failing once.

@daxian-dbw

daxian-dbw commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

I did see failures related to "pathological number" a few times before. But the change to WebCmdlets.Test.ps1 in this PR was already reverted before merging because of the test failure in CI.

@ghost

ghost commented Aug 11, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daxian-dbw @vexx32 @PaulHigin @adityapatwardhan @iSazonov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.