Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update release pipeline to use Approvals and automate some manual tasks#17837

Merged
adityapatwardhan merged 16 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:ManualTasksadityapatwardhan/PowerShell:ManualTasksCopy head branch name to clipboard
Aug 8, 2022
Merged

Update release pipeline to use Approvals and automate some manual tasks#17837
adityapatwardhan merged 16 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:ManualTasksadityapatwardhan/PowerShell:ManualTasksCopy head branch name to clipboard

Conversation

@adityapatwardhan

@adityapatwardhan adityapatwardhan commented Aug 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

  1. Update the task based on environment approval to use Manual tasks
  2. Automate kicking off builds for release automation, vpack and snap
  3. Automate adding change log to the GitHub release draft.

PR Context

PR Checklist

@ghost ghost assigned iSazonov Aug 3, 2022
JamesWTruher
JamesWTruher reviewed Aug 4, 2022
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/releasePipeline.yml Outdated
JamesWTruher
JamesWTruher approved these changes Aug 4, 2022
View reviewed changes

@JamesWTruher JamesWTruher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks fine, but the wait cmdlet will emit progress

Comment thread tools/releaseBuild/azureDevOps/releasePipeline.yml
Comment thread tools/releaseBuild/azureDevOps/releasePipeline.yml Outdated
Set-AzDoProjectInfo -ProjectOwner PowerShell-Rel -ProjectName Release-Automation
$metadata = Get-Content -Raw -Path '$(Pipeline.Workspace)/releasePipeline/metadata/release.json' | ConvertFrom-Json
$azDOBuild = Get-AzDOBuild -buildDefinitionId 10 -MaximumResult 100 | Where-Object { $_.tags -contains $metadata.ReleaseVersion }
$azDoBuild | Remove-AzDOBuildTag -tag 'InProgress' -Pass | Add-AzDOBuildTag -Id $azDOBuild.Id -tag 'SignedOff'

@JamesWTruher JamesWTruher Aug 4, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a check for the job being complete?

@adityapatwardhan adityapatwardhan Aug 4, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for completion in above task

Comment thread tools/releaseBuild/azureDevOps/releasePipeline.yml Outdated
Comment thread tools/releaseBuild/azureDevOps/templates/release-CreateGitHubDraft.yml
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 8, 2022
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 8, 2022
@adityapatwardhan adityapatwardhan marked this pull request as ready for review August 8, 2022 18:04
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Aug 8, 2022

Copy link
Copy Markdown

This PR has 291 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +240 -51
Percentile : 69.1%

Total files changed: 3

Change summary by file extension:
.yml : +240 -51

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit 2eed0f5 into PowerShell:master Aug 8, 2022
@adityapatwardhan adityapatwardhan deleted the ManualTasks branch August 8, 2022 18:56
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 8, 2022
@ghost

ghost commented Aug 11, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
@TravisEz13

TravisEz13 commented Feb 21, 2023

Copy link
Copy Markdown
Member

Shouldn't be a full backport, but only of the manual approval changes

daxian-dbw pushed a commit that referenced this pull request Apr 7, 2023
Merged PR 24413: Add pipeline secrets (from #17837)
11af035
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Apr 12, 2023
@adityapatwardhan @daxian-dbw
Update release pipeline to use Approvals and automate some manual tas…
61465c9 
…ks (PowerShell#17837)
@ghost

ghost commented Apr 13, 2023

Copy link
Copy Markdown

🎉v7.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

+2 more reviewers

@JamesWTruher JamesWTruher JamesWTruher approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adityapatwardhan @TravisEz13 @JamesWTruher @PaulHigin @daxian-dbw @iSazonov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.