Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix type infeerence for ICollection#17752

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
MartinGC94:FixTypeInferenceForICollectionMartinGC94/PowerShell:FixTypeInferenceForICollectionCopy head branch name to clipboard
Jul 25, 2022
Merged

Fix type infeerence for ICollection#17752
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
MartinGC94:FixTypeInferenceForICollectionMartinGC94/PowerShell:FixTypeInferenceForICollectionCopy head branch name to clipboard

Conversation

@MartinGC94

Copy link
Copy Markdown
Contributor

PR Summary

Fixes type inference when accessing indexes of ICollection types like System.Security.AccessControl.AuthorizationRuleCollection for scenarios like (Get-Acl).Access[0].<Tab>
It looks like someone switched two variables around by mistake. I also added a comment to the if statement to explain why it's not doing something the "obvious" way.

PR Context

PR Checklist

@MartinGC94 MartinGC94 requested a review from daxian-dbw as a code owner July 23, 2022 18:32
@MartinGC94 MartinGC94 closed this Jul 23, 2022
@MartinGC94 MartinGC94 reopened this Jul 23, 2022
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 24, 2022

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 5ccbb97 into PowerShell:master Jul 25, 2022
@ghost

ghost commented Aug 12, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.