Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Prevent braces from being removed when completing variables#17751

Merged
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
MartinGC94:DoNotRemoveBracesFromVariableCompletionsMartinGC94/PowerShell:DoNotRemoveBracesFromVariableCompletionsCopy head branch name to clipboard
Jul 25, 2022
Merged

Prevent braces from being removed when completing variables#17751
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
MartinGC94:DoNotRemoveBracesFromVariableCompletionsMartinGC94/PowerShell:DoNotRemoveBracesFromVariableCompletionsCopy head branch name to clipboard

Conversation

@MartinGC94

@MartinGC94 MartinGC94 commented Jul 23, 2022

Copy link
Copy Markdown
Contributor

PR Summary

Adds additional check for adding braces to the variable completion result if the user input includes braces. This fixes variable completion inside strings like: "Hello${psversiont<Tab>}World".
Also makes Null-conditional operator usage with variables slightly more convenient because tab completion won't remove the necessary braces from the variable name.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Jul 23, 2022
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 24, 2022

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 8eb37cc into PowerShell:master Jul 25, 2022
@ghost

ghost commented Aug 12, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.