Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix test performance by stopping ongoing progress-bar#17749

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
fflaten:fix-testsfflaten/PowerShell:fix-testsCopy head branch name to clipboard
Jul 25, 2022
Merged

Fix test performance by stopping ongoing progress-bar#17749
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
fflaten:fix-testsfflaten/PowerShell:fix-testsCopy head branch name to clipboard

Conversation

@fflaten

@fflaten fflaten commented Jul 23, 2022

Copy link
Copy Markdown
Contributor

PR Summary

A progress-bar started in ActionPreference.Tests.ps1 is never completed and causes the the progress-bar to be rendered for all remaining tests including other files, killing the performance.

PR Context

tests-progressactivity

Demo command: Start-PSPester -SkipTestToolBuild -Path /workspaces/PowerShell/test/powershell/Language/Scripting/ActionPreference.Tests.ps1, /workspaces/PowerShell/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1

Before change: 60-70s
After change: 16s

PR Checklist

@ghost ghost assigned daxian-dbw Jul 23, 2022
@fflaten

fflaten commented Jul 23, 2022

Copy link
Copy Markdown
Contributor Author

Related to #17516 ?

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jul 24, 2022
@daxian-dbw daxian-dbw merged commit f1595c4 into PowerShell:master Jul 25, 2022
@fflaten fflaten deleted the fix-tests branch July 25, 2022 18:22
@ghost

ghost commented Aug 11, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.