Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix typo in ModuleCmdletBase.cs#17714

Merged
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
eltociear:patch-11Copy head branch name to clipboard
Jul 20, 2022
Merged

Fix typo in ModuleCmdletBase.cs#17714
iSazonov merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
eltociear:patch-11Copy head branch name to clipboard

Conversation

@eltociear

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

explictly -> explicitly

PR Checklist

@ghost ghost assigned iSazonov Jul 19, 2022

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 20, 2022
@iSazonov

Copy link
Copy Markdown
Collaborator

@daxian-dbw Is it by design that now new PRs get tests from master branch and fails without rebase the dev branch?

@daxian-dbw

Copy link
Copy Markdown
Member

/rebase

@github-actions

github-actions Bot commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Started rebase: https://github.com/PowerShell/PowerShell/actions/runs/2702253441

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

explictly -> explicitly
@daxian-dbw

Copy link
Copy Markdown
Member

I'm not sure. Maybe @adityapatwardhan can comment?

@iSazonov iSazonov merged commit 42d0e99 into PowerShell:master Jul 20, 2022
@iSazonov

Copy link
Copy Markdown
Collaborator

@eltociear Thanks for your contribution!

@ghost

ghost commented Aug 11, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.