Improve hashtable key completion for type constrained variable assignments, nested hashtables and more by MartinGC94 · Pull Request #17660 · PowerShell/PowerShell

MartinGC94 · Jul 10, 2022

PR Summary

Fixes PowerShell/PowerShellEditorServices#1852
Decided to make a full fix for all hashtable key completion scenarios I could think of:

Fixes type inference for ConvertExpressions that use a PowerShell type that hasn't been loaded yet.
Fix tab completion for constructor hashtables so it only completes properties if the class has a null constructor or if it's an interface.
Fix tab completion for constructor hashtables that use a PowerShell type that hasn't been loaded yet.
Fix tab completion for nested hashtables like: Get-WinEvent -FilterHashtable @{SuppressHashFilter=@{<Tab>
Fix tab completion for hashtables that are in an array of arguments like: ls | select Name,@{<Tab>}
Add the same property completion that exists for type conversions to typed variables command parameters and Property assignments
Add completion for the module specification used in using module @{<Tab>

PR Context

PR Checklist

… and command parameters

ghost · Jul 19, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

…e that hasn't been loaded yet. Fix tab completion for constructor hashtables so it only completes properties if the class has a null constructor. Fix tab completion for constructor hashtables that use a PowerShell type that hasn't been loaded yet. Fix tab completion for nested hashtables like Get-WinEvent -FilterHashtable @{SuppressHashFilter=@{<Tab> Fix tab completion for hashtables that are in an array of arguments like: ls | select Name,@{<Tab>} Add the same property completion that exists for type conversions to typed variables command parameters and Property assignments

Fix class name as requested by iSazonov Add enumeration for the inferred types

pull-request-quantifier-deprecated · Dec 14, 2022

This PR has 362 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +256 -106
Percentile : 76.2%

Total files changed: 3

Change summary by file extension:
.cs : +191 -77
.ps1 : +65 -29

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

iSazonov · Dec 14, 2022

@SeeminglyScience Please review.

ghost · Dec 22, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw

Sorry for taking so long to review. Not finished yet, but want to share feedback so far.

daxian-dbw

I'm fine the use of goto LABEL here to break out of the loop. It's not that confusing to get what it does by reading the code.

daxian-dbw · May 1, 2023

@MartinGC94 Thanks for the contribution and I appreciate your patience.

andyleejordan · May 2, 2023

This is awesome work!

ghost · Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Add completion for hashtable property definitions for typed variables…

15aae32

… and command parameters

pull-request-quantifier-deprecated Bot added the Small label Jul 10, 2022

ghost assigned anmenaga Jul 10, 2022

iSazonov requested review from SeeminglyScience and daxian-dbw July 12, 2022 06:33

ghost added the Review - Needed The PR is being reviewed label Jul 19, 2022

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 20, 2022

dkaszews reviewed Aug 2, 2022

View reviewed changes

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs

iSazonov approved these changes Aug 3, 2022

View reviewed changes

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs

Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated

pull-request-quantifier-deprecated Bot added Large and removed Small labels Aug 8, 2022

MartinGC94 changed the title ~~Add completion for hashtable property definitions for typed variables~~ WIP: Add completion for hashtable property definitions for typed variables Aug 8, 2022

MartinGC94 and others added 2 commits August 9, 2022 21:46

Merge branch 'master' into AddCompletionForTypedVariables

7bf6736

Add missing tests

1455f2e

Fix class name as requested by iSazonov Add enumeration for the inferred types

MartinGC94 changed the title ~~WIP: Add completion for hashtable property definitions for typed variables~~ Improve hashtable key completion for type constrained variable assignments, nested hashtables and more Aug 11, 2022

Exclude interfaces from the null constructor check

5a46afd

MartinGC94 closed this Aug 15, 2022

MartinGC94 reopened this Aug 15, 2022

MartinGC94 and others added 3 commits August 18, 2022 18:03

Add completion for module specification keys in using module statement

c715ee5

Merge branch 'master' into AddCompletionForTypedVariables

eb05d9e

Merge branch 'PowerShell:master' into AddCompletionForTypedVariables

31474e2

ghost removed the Review - Needed The PR is being reviewed label Dec 14, 2022

ghost added the Review - Needed The PR is being reviewed label Dec 22, 2022

daxian-dbw reviewed Apr 25, 2023

View reviewed changes

Merge branch 'PowerShell:master' into AddCompletionForTypedVariables

81f5468

Apply Dongbo suggestion.

7e435e5

daxian-dbw reviewed Apr 25, 2023

View reviewed changes

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs

Return early when encountering unexpected Ast

12cf01f

daxian-dbw added the CommunityDay-Large A large PR that the PS team has identified to prioritize to review label May 1, 2023

daxian-dbw approved these changes May 1, 2023

View reviewed changes

daxian-dbw merged commit 5605b24 into PowerShell:master May 1, 2023

ghost removed the Review - Needed The PR is being reviewed label May 1, 2023

ghost mentioned this pull request Jun 29, 2023

Install-Module failed: Issue with converting to SemanticVersion in Install-Package #1852

Closed

Search code, repositories, users, issues, pull requests...

Conversation

MartinGC94 commented Jul 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

ghost commented Jul 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pull-request-quantifier-deprecated Bot commented Dec 14, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

iSazonov commented Dec 14, 2022

Uh oh!

ghost commented Dec 22, 2022

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

daxian-dbw commented May 1, 2023

Uh oh!

andyleejordan commented May 2, 2023

Uh oh!

ghost commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MartinGC94 commented Jul 10, 2022 •

edited

Loading