Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add AppX capabilities in MSIX manifest so that PS7 can call the AppX APIs#17416

Merged
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:msix-appxSteveL-MSFT/PowerShell:msix-appxCopy head branch name to clipboard
May 23, 2022
Merged

Add AppX capabilities in MSIX manifest so that PS7 can call the AppX APIs#17416
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
SteveL-MSFT:msix-appxSteveL-MSFT/PowerShell:msix-appxCopy head branch name to clipboard

Conversation

@SteveL-MSFT

@SteveL-MSFT SteveL-MSFT commented May 23, 2022

Copy link
Copy Markdown
Member

PR Summary

Two additional capabilities need to be requested for the PS7 MSIX install to work correctly with AppX module.

PR Context

Been working with AppX team to make their module work in both WinPS and PS7. These caps are the last piece needed to work with the Store installed version. Validated by AppX engineer with a private build.

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +2 -0
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.xml : +2 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 enabled auto-merge (squash) May 23, 2022 21:45
@TravisEz13 TravisEz13 merged commit da6fde0 into PowerShell:master May 23, 2022
@SteveL-MSFT SteveL-MSFT deleted the msix-appx branch May 24, 2022 00:00
@adityapatwardhan

Copy link
Copy Markdown
Member

This needs more bake time. We need at least once preview release is done.

@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 20, 2022
@ghost

ghost commented Jun 22, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan

Copy link
Copy Markdown
Member

/backport to release/v7.2.6

@github-actions

github-actions Bot commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.6: https://github.com/PowerShell/PowerShell/actions/runs/2784805911

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@ghost

ghost commented Aug 11, 2022

Copy link
Copy Markdown

🎉v7.2.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.