Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix mariner mappings#17413

Merged
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
TravisEz13-patch-8PowerShell/PowerShell:TravisEz13-patch-8Copy head branch name to clipboard
May 23, 2022
Merged

Fix mariner mappings#17413
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
TravisEz13-patch-8PowerShell/PowerShell:TravisEz13-patch-8Copy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented May 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

PR Context

PR Checklist

@ghost ghost assigned PaulHigin May 23, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented May 23, 2022

Copy link
Copy Markdown

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +2 -2
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.json : +2 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit 90703cb into master May 23, 2022
@TravisEz13 TravisEz13 deleted the TravisEz13-patch-8 branch May 23, 2022 17:46
@TravisEz13

TravisEz13 commented May 23, 2022

Copy link
Copy Markdown
Member Author

/backport to release/v7.2.5

@github-actions

github-actions Bot commented May 23, 2022 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2374311804

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions

github-actions Bot commented May 23, 2022

Copy link
Copy Markdown
Contributor

@TravisEz13 backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix mariner mappings
Using index info to reconstruct a base tree...
M	tools/packages.microsoft.com/mapping.json
Falling back to patching base and 3-way merge...
Auto-merging tools/packages.microsoft.com/mapping.json
CONFLICT (content): Merge conflict in tools/packages.microsoft.com/mapping.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix mariner mappings
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@adityapatwardhan

adityapatwardhan commented May 24, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.2.5

@github-actions

github-actions Bot commented May 24, 2022 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2380566246

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions

github-actions Bot commented May 24, 2022

Copy link
Copy Markdown
Contributor

@adityapatwardhan backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix mariner mappings
Using index info to reconstruct a base tree...
M	tools/packages.microsoft.com/mapping.json
Falling back to patching base and 3-way merge...
Auto-merging tools/packages.microsoft.com/mapping.json
CONFLICT (content): Merge conflict in tools/packages.microsoft.com/mapping.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix mariner mappings
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request May 24, 2022
@TravisEz13
Fix mariner mappings (PowerShell#17413)
6806cac 
# Conflicts:
#	tools/packages.microsoft.com/mapping.json
@TravisEz13

TravisEz13 commented May 31, 2022

Copy link
Copy Markdown
Member Author

/backport to release/v7.2.5

@github-actions

github-actions Bot commented May 31, 2022 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2416850560

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions

github-actions Bot commented May 31, 2022

Copy link
Copy Markdown
Contributor

@TravisEz13 backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix mariner mappings
Using index info to reconstruct a base tree...
M	tools/packages.microsoft.com/mapping.json
Falling back to patching base and 3-way merge...
Auto-merging tools/packages.microsoft.com/mapping.json
CONFLICT (content): Merge conflict in tools/packages.microsoft.com/mapping.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix mariner mappings
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

TravisEz13 added a commit that referenced this pull request May 31, 2022
@TravisEz13
Fix mariner mappings (#17413)
5c804e2
@TravisEz13

TravisEz13 commented May 31, 2022

Copy link
Copy Markdown
Member Author

backported to 7.2 5c804e2

@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 16, 2022
@ghost

ghost commented Jun 21, 2022

Copy link
Copy Markdown

🎉v7.2.5 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Jun 22, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PaulHigin PaulHigin

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TravisEz13 @adityapatwardhan @PaulHigin
Morty Proxy This is a proxified and sanitized view of the page, visit original site.