Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Ensure alpine and arm SKUs have powershell.config.json file with experimental features enabled#16823

Merged
adityapatwardhan merged 10 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FixAlpineConfigJsonadityapatwardhan/PowerShell:FixAlpineConfigJsonCopy head branch name to clipboard
Feb 4, 2022
Merged

Ensure alpine and arm SKUs have powershell.config.json file with experimental features enabled#16823
adityapatwardhan merged 10 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:FixAlpineConfigJsonadityapatwardhan/PowerShell:FixAlpineConfigJsonCopy head branch name to clipboard

Conversation

@adityapatwardhan

@adityapatwardhan adityapatwardhan commented Feb 1, 2022

Copy link
Copy Markdown
Member

PR Summary

We needed to invoke pwsh to generate the list of experimental features. Hence, it did not work on cross compiled packages like ARM and Alpine. Now we have static file with the experimental feature list. This is used as the source of truth for listing the experimental feature to be included in the powershell.config.json.

Updated build configurations to use the experimental files json.

PR Context

PR Checklist

@ghost ghost assigned iSazonov Feb 1, 2022
PaulHigin
PaulHigin approved these changes Feb 1, 2022
View reviewed changes
Comment thread tools/UpdateDotnetRuntime.ps1 Outdated
daxian-dbw
daxian-dbw reviewed Feb 1, 2022
View reviewed changes
Comment thread ExperimentalFeatures.json Outdated
Comment thread build.psm1 Outdated
@adityapatwardhan

adityapatwardhan commented Feb 4, 2022

Copy link
Copy Markdown
Member Author

@TravisEz13 @daxian-dbw Please re-review

TravisEz13
TravisEz13 reviewed Feb 4, 2022
View reviewed changes
Comment thread build.psm1 Outdated
adityapatwardhan and others added 2 commits February 4, 2022 12:41
@adityapatwardhan @TravisEz13
Update build.psm1
689b7e6 
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
@adityapatwardhan
Make sure windows has config file when there are not experimental fea…
9349d03 
…tures
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Feb 4, 2022

Copy link
Copy Markdown

This PR has 32 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +12 -20
Percentile : 12.8%

Total files changed: 1

Change summary by file extension:
.psm1 : +12 -20

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit bcc1f10 into PowerShell:master Feb 4, 2022
@adityapatwardhan adityapatwardhan deleted the FixAlpineConfigJson branch February 4, 2022 23:21
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 4, 2022
@iSazonov iSazonov removed their assignment Feb 5, 2022
@ghost

ghost commented Feb 24, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@adityapatwardhan @TravisEz13
Ensure alpine and arm SKUs have powershell.config.json file with ex…
00917b0 
…perimental features enabled (PowerShell#16823)
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 14, 2022
@adityapatwardhan @TravisEz13
Ensure alpine and arm SKUs have powershell.config.json file with ex…
d99625c 
…perimental features enabled (PowerShell#16823)

# Conflicts:
#	build.psm1
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 15, 2022
@adityapatwardhan @TravisEz13
Ensure alpine and arm SKUs have powershell.config.json file with ex…
e854b87 
…perimental features enabled (PowerShell#16823)

# Conflicts:
#	build.psm1
@ghost

ghost commented Mar 16, 2022

Copy link
Copy Markdown

🎉v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Mar 16, 2022

Copy link
Copy Markdown

🎉v7.2.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
@unfurl-links unfurl-links Bot mentioned this pull request Nov 7, 2022
Merged
13 tasks
@daxian-dbw daxian-dbw mentioned this pull request Nov 7, 2022
Closed
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adityapatwardhan @daxian-dbw @TravisEz13 @PaulHigin @iSazonov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.