Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use more efficient platform detection API#16760

Merged
PaulHigin merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:cleanup-operatingsystem-apiiSazonov/PowerShell:cleanup-operatingsystem-apiCopy head branch name to clipboard
Jan 27, 2022
Merged

Use more efficient platform detection API#16760
PaulHigin merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:cleanup-operatingsystem-apiiSazonov/PowerShell:cleanup-operatingsystem-apiCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Jan 17, 2022

Copy link
Copy Markdown
Collaborator

PR Summary

Use static and const new OperatingSystem class API to avoid string comparisons and extra allocations.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 17, 2022
@ghost ghost assigned PaulHigin Jan 17, 2022
@iSazonov iSazonov force-pushed the cleanup-operatingsystem-api branch from 381ad8e to b97efea Compare January 17, 2022 06:27
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 18, 2022

@PaulHigin PaulHigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use static and const new OperatingSystem class API to avoid string comparisons and extra allocations.
@iSazonov iSazonov force-pushed the cleanup-operatingsystem-api branch from 6231fab to 2df0e80 Compare January 19, 2022 04:25
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 31 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +15 -16
Percentile : 12.4%

Total files changed: 9

Change summary by file extension:
.cs : +15 -16

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost added the Review - Needed The PR is being reviewed label Jan 26, 2022
@ghost

ghost commented Jan 26, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHigin

Copy link
Copy Markdown
Contributor

@iSazonov Can you please fill out the PR checklist above?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 26, 2022
@iSazonov

Copy link
Copy Markdown
Collaborator Author

@PaulHigin Done.

@ghost

ghost commented Feb 24, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.