Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adding VBS feature names to Get-ComputerInfo#16415

Merged
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
mattifestation:masterCopy head branch name to clipboard
Jul 26, 2022
Merged

Adding VBS feature names to Get-ComputerInfo#16415
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
mattifestation:masterCopy head branch name to clipboard

Conversation

@mattifestation

@mattifestation mattifestation commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

Adding new Virtualization-Based Security (VBS) feature names to the Get-ComputerInfo cmdlet. This commit addresses issue #16357

PR Summary

This PR adds supported Virtualization-Based Security (VBS) feature names to the Get-ComputerInfo cmdlet. This PR addresses issue #16357.

Thank you for your consideration.

PR Context

Upon merging this PR, users of Windows Defender Application Control (WDAC) will benefit more greatly from Get-ComputerInfo in that it will present all available VBS features in a human-readable fashion, as Get-ComputerInfo intended. The feature names added in this PR will also offer parity with the feature names presented in the msinfo32.exe UI.

Note: this change would also ideally need to be backported to Windows PowerShell.

PR Checklist

@mattifestation
Adding VBS feature names to Get-ComputerInfo
aaf84fc 
Adding new Virtualization-Based Security (VBS) feature names to the Get-ComputerInfo cmdlet. This commit addresses issue #16357
@ghost ghost assigned iSazonov Nov 9, 2021
@ghost

ghost commented Nov 9, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@iSazonov

iSazonov commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

It would be great to update tests. Get-StringValuesFromValueMap does one way check and don't catch the absence before.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 9, 2021
@mattifestation
Adding VBS features to Get-ComputerInfo.Tests.ps1
0efdffc 
The update to this test addresses issue #16357 and updates PR #16415. Now, there will be a 1:1 mapping of VBS feature names to be tested alongside the newly implemented feature names in `GetComputerInfoCommand.cs`. Thank you for the suggestion, @iSazonov.
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Nov 9, 2021

Copy link
Copy Markdown

This PR has 8 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -2
Percentile : 3.2%

Total files changed: 2

Change summary by file extension:
.cs : +4 -1
.ps1 : +2 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov

iSazonov commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

I think the test is broken because it doesn't catch the issue. The test checks seem only valid return values but it doesn't check absence of values.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 19, 2021
@ghost

ghost commented Nov 19, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

SteveL-MSFT
SteveL-MSFT approved these changes Jul 25, 2022
View reviewed changes

@SteveL-MSFT SteveL-MSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is marked as Pending and I'm not sure what values will show up in CI/CD instances

@iSazonov iSazonov closed this Jul 26, 2022
@iSazonov iSazonov reopened this Jul 26, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 26, 2022
@iSazonov

iSazonov commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

Manually checked - new values present in output:
image

@iSazonov iSazonov merged commit 6bf8a98 into PowerShell:master Jul 26, 2022
@iSazonov

iSazonov commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

@mattifestation Thanks for your contribution!

@ghost

ghost commented Aug 12, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattifestation @iSazonov @SteveL-MSFT
Morty Proxy This is a proxified and sanitized view of the page, visit original site.