Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Authenticode https fix issue #12827#16134

Merged
TravisEz13 merged 6 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
DariusHutchison:authenticode-https-fixDariusHutchison/PowerShell:authenticode-https-fixCopy head branch name to clipboard
Aug 1, 2022
Merged

Authenticode https fix issue #12827#16134
TravisEz13 merged 6 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
DariusHutchison:authenticode-https-fixDariusHutchison/PowerShell:authenticode-https-fixCopy head branch name to clipboard

Conversation

@ghost

@ghost ghost commented Sep 22, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

PR Summary

A fix for issue #12827

PR Context

The Set-AuthenticodeSignature command only allows the use of an http timestamp server only. I added https:// as also a valid prefix.

PR Checklist

@ghost ghost assigned iSazonov Sep 22, 2021
@PaulHigin PaulHigin added WG-Security security related areas such as JEA Needs-Triage The issue is new and needs to be triaged by a work group. labels Sep 22, 2021
@ghost

ghost commented Sep 22, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ghost ghost marked this pull request as ready for review September 22, 2021 17:48
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 30, 2021
@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

TravisEz13
TravisEz13 reviewed Oct 3, 2021
View reviewed changes
Comment thread src/System.Management.Automation/security/Authenticode.cs Outdated
TravisEz13
TravisEz13 requested changes Oct 3, 2021
View reviewed changes

@TravisEz13 TravisEz13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 3, 2021
@TravisEz13
Update src/System.Management.Automation/security/Authenticode.cs
6133cbb 
I agree.

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 4, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 12, 2021
@ghost

ghost commented Oct 12, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@PaulHigin

PaulHigin commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

@Ryan-Hutchison-USAF Can you please make the change requested by @TravisEz13?

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 15, 2021
@PaulHigin PaulHigin removed the Needs-Triage The issue is new and needs to be triaged by a work group. label Nov 15, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 23, 2021
@ghost

ghost commented Nov 23, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov closed this Jul 26, 2022
@iSazonov iSazonov reopened this Jul 26, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 26, 2022
@iSazonov

iSazonov commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

@TravisEz13 Please update your review.

@TravisEz13 TravisEz13 merged commit f2204a0 into PowerShell:master Aug 1, 2022
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 1, 2022
@ghost

ghost commented Aug 12, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@sdwheeler sdwheeler mentioned this pull request Aug 12, 2022
Closed
2 tasks
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Feb 27, 2025
@cemuram cemuram mentioned this pull request Mar 6, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed WG-Security security related areas such as JEA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PaulHigin @iSazonov @TravisEz13 @SteveL-MSFT @DariusHutchison
Morty Proxy This is a proxified and sanitized view of the page, visit original site.