Specify exe path as TargetObect for non-zero exit code ErrorRecord#16108
Merged
rjmholt merged 1 commit intoOct 14, 2021
PowerShell:masterPowerShell/PowerShell:masterfrom
rkeithhill:rkeithhill/specify-exe-full-path-as-target-objectrkeithhill/PowerShell:rkeithhill/specify-exe-full-path-as-target-objectCopy head branch name to clipboard
Merged
Specify exe path as TargetObect for non-zero exit code ErrorRecord#16108rjmholt merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom rkeithhill:rkeithhill/specify-exe-full-path-as-target-objectrkeithhill/PowerShell:rkeithhill/specify-exe-full-path-as-target-objectCopy head branch name to clipboard
rjmholt merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
rkeithhill:rkeithhill/specify-exe-full-path-as-target-objectrkeithhill/PowerShell:rkeithhill/specify-exe-full-path-as-target-objectCopy head branch name to clipboard
Conversation
iSazonov
approved these changes
Sep 16, 2021
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
Author
|
@rjmholt Any chance you could give this a quick review? Also, since it appears we're still doing previews any chance we could get this whole experimental feature in for 7.2? |
rjmholt
approved these changes
Oct 7, 2021
Collaborator
|
@rkeithhill this experimental feature wasn't taken for 7.2 (since it came in late), so it and this PR will be released in 7.3 preview 1 |
Collaborator
Author
|
🎉 Handy links: |
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR changes the TargetObject for the ErrorCode to the full native command's path. This ErrorRecord is generated as part of the experimental feature PSNativeCommandErrorActionPreference.
PR Context
Fix #15992
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).