(#15949) Fix regression in Add-History#16005
Merged
daxian-dbw merged 2 commits intoAug 27, 2021
PowerShell:masterPowerShell/PowerShell:masterfrom
vexx32:15949/history-datetime-formatvexx32/PowerShell:15949/history-datetime-formatCopy head branch name to clipboard
Merged
(#15949) Fix regression in Add-History#16005daxian-dbw merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom vexx32:15949/history-datetime-formatvexx32/PowerShell:15949/history-datetime-formatCopy head branch name to clipboard
daxian-dbw merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
vexx32:15949/history-datetime-formatvexx32/PowerShell:15949/history-datetime-formatCopy head branch name to clipboard
Conversation
Add-History was not respecting the culture settings and throwing when given any non-US datetime format. Fixed by ensuring we use the current culture for the conversion.
62fe083 to
51cc480
Compare
iSazonov
approved these changes
Aug 26, 2021
| } | ||
| ) | ||
|
|
||
| $oldCulture = [cultureinfo]::CurrentCulture |
Collaborator
There was a problem hiding this comment.
Here and below:
Suggested change
| $oldCulture = [cultureinfo]::CurrentCulture | |
| $oldCulture = [CultureInfo]::CurrentCulture |
Collaborator
There was a problem hiding this comment.
We seem to have a type accelerator for this, so I'd argue that [cultureinfo] is preferred, like [bool] or [pscustomobject]
daxian-dbw
approved these changes
Aug 26, 2021
rjmholt
approved these changes
Aug 26, 2021
xtqqczze
pushed a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Sep 2, 2021
TravisEz13
pushed a commit
that referenced
this pull request
Sep 29, 2021
|
🎉 Handy links: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Use CurrentCulture when handling conversions to DateTime in Add-History.
PR Context
Fixing a regression in Add-History that was inadvertently introduced in #12495 and made the conversions used by Add-History culture invariant by mistake.
Fixes #15949
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).