Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add more information when a syslog parsing error occurs#15857

Merged
rjmholt merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
JamesWTruher:SyslogTest002JamesWTruher/PowerShell-1:SyslogTest002Copy head branch name to clipboard
Aug 4, 2021
Merged

Add more information when a syslog parsing error occurs#15857
rjmholt merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
JamesWTruher:SyslogTest002JamesWTruher/PowerShell-1:SyslogTest002Copy head branch name to clipboard

Conversation

@JamesWTruher

@JamesWTruher JamesWTruher commented Aug 2, 2021

Copy link
Copy Markdown
Collaborator

PR Summary

still no repro outside of our nightly builds.
I have hardened the code a bit more and added additional debugging output in case other exceptions are generated.
It appears that the syslog file contains data that the helper module cannot deal with, so I've added additional output to help understand what that data looks like.

PR Context

we are having a build breaking test failure which has been difficult to reproduce.

PR Checklist

@JamesWTruher JamesWTruher changed the title WIP: Add more information when a parsing error occurs Add more information when a syslog parsing error occurs Aug 3, 2021
@rjmholt rjmholt self-assigned this Aug 4, 2021
@rjmholt rjmholt marked this pull request as ready for review August 4, 2021 17:19
Comment thread test/tools/Modules/PSSysLog/PSSysLog.psm1 Outdated
@rjmholt rjmholt enabled auto-merge (squash) August 4, 2021 17:20
@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Aug 4, 2021
@rjmholt rjmholt merged commit 5fea4c3 into PowerShell:master Aug 4, 2021
@ghost

ghost commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

ghost commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

@JamesWTruher JamesWTruher deleted the SyslogTest002 branch September 23, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.